From: Arjan van de Ven <arjan@infradead.org>
To: Michael Breuer <mbreuer@majjas.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug (minor): microcode_intel.c applies updates to hyperthreaded cores
Date: Wed, 2 Dec 2009 20:20:12 -0800 [thread overview]
Message-ID: <20091202202012.0c7b6768@infradead.org> (raw)
In-Reply-To: <4B17393B.7000304@majjas.com>
On Wed, 02 Dec 2009 23:06:19 -0500
Michael Breuer <mbreuer@majjas.com> wrote:
> According to spec, microcode should only be applied to actual cores.
> As things are currently structured, looks like the fix would be in
> microcode_core.c. I don't think changing the loop to look for cores
> vs. cpu's would affect anything adversely, but honestly am not
> familiar enough with this code or other cpu types to be sure.
>
isn't this
for each (logical) cpu
check microcode version of the cpu
if too old, apply microcode
the 2nd pair of a hyperthreading pair will never see the 'too old' case
happen...
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-12-03 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 4:06 Bug (minor): microcode_intel.c applies updates to hyperthreaded cores Michael Breuer
2009-12-03 4:20 ` Arjan van de Ven [this message]
2009-12-03 4:34 ` Michael Breuer
2009-12-03 4:46 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202202012.0c7b6768@infradead.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbreuer@majjas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox