From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: Re: [PATCH tip/core/rcu 1/4] rcu: rename "quiet" functions
Date: Wed, 2 Dec 2009 15:20:57 -0800 [thread overview]
Message-ID: <20091202232056.GA5479@feather> (raw)
In-Reply-To: <12597846163698-git-send-email->
On Wed, Dec 02, 2009 at 12:10:13PM -0800, Paul E. McKenney wrote:
> The number of "quiet" functions has grown recently, and the names are
> no longer very descriptive. The point of all of these functions is to
> do some portion of the task of reporting a quiescent state, so rename
> them accordingly:
>
> o cpu_quiet() becomes rcu_report_qs_rdp(), which reports a
> quiescent state to the per-CPU rcu_data structure. If this
> turns out to be a new quiescent state for this grace period,
> then rcu_report_qs_rnp() will be invoked to propagate the
> quiescent state up the rcu_node hierarchy.
>
> o cpu_quiet_msk() becomes rcu_report_qs_rnp(), which reports
> a quiescent state for a given CPU (or possibly a set of CPUs)
> up the rcu_node hierarchy.
>
> o cpu_quiet_msk_finish() becomes rcu_report_qs_rsp(), which
> reports a full set of quiescent states to the global rcu_state
> structure.
>
> o task_quiet() becomes rcu_report_unblock_qs_rnp(), which reports
> a quiescent state due to a task exiting an RCU read-side critical
> section that had previously blocked in that same critical section.
> As indicated by the new name, this type of quiescent state is
> reported up the rcu_node hierarchy (using rcu_report_qs_rnp()
> to do so).
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
*Huge* improvement in terminology.
Acked-by: Josh Triplett <josh@joshtriplett.org>
next prev parent reply other threads:[~2009-12-02 23:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 20:09 [PATCH tip/core/rcu 0/4] rcu: preemptible expedited grace periods and cleanups Paul E. McKenney
2009-12-02 20:10 ` [PATCH tip/core/rcu 1/4] rcu: rename "quiet" functions Paul E. McKenney
2009-12-02 23:20 ` Josh Triplett [this message]
2009-12-03 13:22 ` [tip:core/rcu] rcu: Rename " tip-bot for Paul E. McKenney
2009-12-02 20:10 ` [PATCH tip/core/rcu 2/4] rcu: enable fourth level of TREE_RCU hierarchy Paul E. McKenney
2009-12-02 23:25 ` Josh Triplett
2009-12-03 0:20 ` Paul E. McKenney
2009-12-03 13:22 ` [tip:core/rcu] rcu: Enable " tip-bot for Paul E. McKenney
2009-12-02 20:10 ` [PATCH tip/core/rcu 3/4] rcu: add expedited grace-period support for preemptible RCU Paul E. McKenney
2009-12-03 9:26 ` Lai Jiangshan
2009-12-03 14:41 ` Paul E. McKenney
2009-12-03 13:22 ` [tip:core/rcu] rcu: Add " tip-bot for Paul E. McKenney
2009-12-02 20:10 ` [PATCH tip/core/rcu 4/4] rcu: make RCU's CPU-stall detector be default Paul E. McKenney
2009-12-03 13:22 ` [tip:core/rcu] rcu: Make " tip-bot for Paul E. McKenney
2009-12-03 8:53 ` [PATCH tip/core/rcu 0/4] rcu: preemptible expedited grace periods and cleanups Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202232056.GA5479@feather \
--to=josh@joshtriplett.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox