From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Eric Paris <eparis@parisplace.org>,
linux-security-module@vger.kernel.org, akpm@linux-foundation.org,
Amerigo Wang <amwang@redhat.com>,
James Morris <jmorris@namei.org>
Subject: [Patch] selinux: remove a useless return
Date: Thu, 3 Dec 2009 03:48:28 -0500 [thread overview]
Message-ID: <20091203085127.4370.1737.sendpatchset@localhost.localdomain> (raw)
The last return is unreachable, remove the 'return'
in default, let it fall through.
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: James Morris <jmorris@namei.org>
Cc: Eric Paris <eparis@parisplace.org>
---
diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
index b5407f1..718823d 100644
--- a/security/selinux/ss/mls.c
+++ b/security/selinux/ss/mls.c
@@ -542,7 +542,7 @@ int mls_compute_sid(struct context *scontext,
/* Use the process effective MLS attributes. */
return mls_context_cpy_low(newcontext, scontext);
default:
- return -EINVAL;
+ /* Fallthrough */
}
return -EINVAL;
}
next reply other threads:[~2009-12-03 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 8:48 Amerigo Wang [this message]
2009-12-03 14:23 ` [Patch] selinux: remove a useless return Eric Paris
2009-12-07 13:32 ` Dan Carpenter
2009-12-08 9:54 ` Cong Wang
2009-12-07 22:26 ` James Morris
2009-12-08 9:55 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203085127.4370.1737.sendpatchset@localhost.localdomain \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox