Re: [Patch 1/2] GRU - function to generate chipset IPI values

[Jack Steiner <steiner@sgi.com>]

On Thu, Dec 03, 2009 at 03:19:12PM -0800, Andrew Morton wrote:
> On Thu, 03 Dec 2009 16:34:15 -0600
> steiner@sgi.com wrote:
> 
> > From: Jack Steiner <steiner@sgi.com>
> > 
> > Create a function to generate the value that is written to the UV hub
> > MMR to cause an IPI interrupt to be sent. The function will be
> > used in the GRU message queue error recovery code that sends IPIs to
> > nodes in remote partitions.
> > 
> > ...
> >
> > +static unsigned long uv_hub_ipi_value(int apicid, int vector, int mode)
> > +{
> > +	return (1UL << UVH_IPI_INT_SEND_SHFT) |
> > +			((apicid) << UVH_IPI_INT_APIC_ID_SHFT) |
> > +			(mode << UVH_IPI_INT_DELIVERY_MODE_SHFT) |
> > +			(vector << UVH_IPI_INT_VECTOR_SHFT);
> > +}
> 
> You've taken care to avoid a shift overflow of "1", but not of
> `apicid', `vector' and `mode'.
> 
> Maybe the compiler does that, I forget.
 
I sure hate the 32/64 bit issues with shifts of ints. I am bitten by
that more than I'd like.

I think we are ok in this case.  In the above code, all of the fields
of the result except bit 63 reside in the low 32 bits of the resulting
unsigned long. I think that makes it work.

--- jack