public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dev@uclinux.org
Cc: David Howells <dhowells@redhat.com>,
	linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
	uclinux-dist-devel@blackfin.uclinux.org,
	David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack
Date: Fri, 4 Dec 2009 02:07:08 -0500	[thread overview]
Message-ID: <200912040207.09801.vapier@gentoo.org> (raw)
In-Reply-To: <16680.1259863084@redhat.com>

[-- Attachment #1: Type: Text/Plain, Size: 716 bytes --]

On Thursday 03 December 2009 12:58:04 David Howells wrote:
> Mike Frysinger <vapier.adi@gmail.com> wrote:
> > i have seen a few apps use brk()/sbrk() to query the size of things (like
> > e2fsprogs)
> 
> We do actually record the size of the brk segment, so maybe we could icache
> flush brk as it is increased (if it is increased):
> 
> 	diff --git a/mm/nommu.c b/mm/nommu.c
> 	index 3754b16..2ea823d 100644
> 	--- a/mm/nommu.c
> 	+++ b/mm/nommu.c
> 	@@ -432,6 +432,7 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)
> 		/*
> 		 * Ok, looks good - let it rip.
> 		 */
> 	+	flush_icache_range(mm->brk, brk);
> 		return mm->brk = brk;
> 	 }

probably want mm->brk + brk for the second argument
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-12-04  7:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 15:24 [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack Mike Frysinger
2009-11-28 18:47 ` [uClinux-dev] " Mike Frysinger
2009-12-02 13:44 ` David Howells
2009-12-02 21:29   ` [uClinux-dev] " Mike Frysinger
2009-12-03 17:58     ` David Howells
2009-12-04  7:07       ` Mike Frysinger [this message]
2009-12-04  9:40         ` David Howells
2009-12-04 10:26           ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912040207.09801.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=davidm@snapgear.com \
    --cc=dhowells@redhat.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox