From: Alexey Dobriyan <adobriyan@gmail.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
chris.mason@oracle.com, konishi.ryusuke@lab.ntt.co.jp,
swhiteho@redhat.com, tytso@mit.edu
Subject: Re: + task_struct-make-journal_info-conditional.patch added to -mm tree
Date: Fri, 4 Dec 2009 08:17:29 +0300 [thread overview]
Message-ID: <20091204051729.GA3927@x200> (raw)
In-Reply-To: <4B1888CE.8000406@ct.jp.nec.com>
On Fri, Dec 04, 2009 at 12:58:06PM +0900, Hiroshi Shimamoto wrote:
> Alexey Dobriyan wrote:
> > On Thu, Dec 03, 2009 at 02:40:57PM -0800, akpm@linux-foundation.org wrote:
> >> --- a/include/linux/sched.h~task_struct-make-journal_info-conditional
> >> +++ a/include/linux/sched.h
> >> @@ -1452,8 +1452,10 @@ struct task_struct {
> >> gfp_t lockdep_reclaim_gfp;
> >> #endif
> >>
> >> +#ifdef CONFIG_FS_JOURNAL_INFO
> >> /* journalling filesystem info */
> >> void *journal_info;
> >> +#endif
> >
> > This will prevent using e.g. ext3 on CONFIG_EXT3_FS=n kernels.
>
> I'm sorry, I'm not sure what you're mentioning.
With this patch admin must decide in advance if he will ever use ext3.
EXT3_FS=n kernels won't be able to get ext3 support without reboot
even as module, because task_struct will be different.
Which is a regression compared to current state.
The biggest example of such behaviour is ipv6 module, but it should not
be spread more.
next prev parent reply other threads:[~2009-12-04 5:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912032240.nB3Mevae027408@imap1.linux-foundation.org>
2009-12-04 2:14 ` + task_struct-make-journal_info-conditional.patch added to -mm tree Alexey Dobriyan
2009-12-04 3:58 ` Hiroshi Shimamoto
2009-12-04 5:17 ` Alexey Dobriyan [this message]
2009-12-04 9:31 ` Steven Whitehouse
2009-12-07 2:28 ` Hiroshi Shimamoto
2009-12-07 4:30 ` Alexey Dobriyan
2009-12-07 9:29 ` Ryusuke Konishi
2009-12-08 0:32 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204051729.GA3927@x200 \
--to=adobriyan@gmail.com \
--cc=chris.mason@oracle.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox