From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Amit Kucheria <amit.kucheria@canonical.com>
Cc: List Linux Kernel <linux-kernel@vger.kernel.org>,
Dinh.Nguyen@freescale.com, s.hauer@pengutronix.de,
grant.likely@secretlab.ca, r.herring@freescale.com,
linux-arm-kernel@lists.infradead.org, daniel@caiaq.de,
valentin.longchamp@epfl.ch
Subject: Re: [RFC][PATCH 04/10] arm: mxc: Fix Drive Strength Field in the IOMUX controller
Date: Fri, 4 Dec 2009 10:38:24 +0100 [thread overview]
Message-ID: <20091204093824.GB10910@pengutronix.de> (raw)
In-Reply-To: <a079a0627e77f2df590840e4798fc067f4436160.1259893118.git.amit.kucheria@canonical.com>
Hello,
On Fri, Dec 04, 2009 at 04:47:04AM +0200, Amit Kucheria wrote:
> i.MX51 defines 4 values:
>
> 00: Low Drive Strength
> 01: Medium Drive Strength
> 10: High Drive Strength
> 11: Max Drive Strength
>
> Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
> ---
> arch/arm/plat-mxc/include/mach/iomux-v3.h | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> index a0fa402..8c351d6 100644
> --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h
> +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> @@ -81,11 +81,13 @@ struct pad_desc {
>
> #define PAD_CTL_ODE (1 << 3)
>
> -#define PAD_CTL_DSE_STANDARD (0 << 1)
> -#define PAD_CTL_DSE_HIGH (1 << 1)
> -#define PAD_CTL_DSE_MAX (2 << 1)
> +#define PAD_CTL_DSE_LOW (0 << 1)
> +#define PAD_CTL_DSE_MED (1 << 1)
> +#define PAD_CTL_DSE_HIGH (2 << 1)
> +#define PAD_CTL_DSE_MAX (3 << 1)
Does the new values work on other SOCs having iomux-v3, too?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-12-04 9:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 2:47 [RFC][PATCH 00/10] Base support for Freescale i.MX51 SoC platform Amit Kucheria
2009-12-04 2:47 ` [RFC][PATCH 01/10] arm: mxc: New interrupt controller (TZIC) for i.MX5 family Amit Kucheria
2009-12-04 3:59 ` Andres Salomon
2009-12-04 9:36 ` Uwe Kleine-König
2009-12-04 10:38 ` Russell King - ARM Linux
2009-12-04 17:01 ` Randy Dunlap
2009-12-04 20:30 ` Amit Kucheria
2009-12-04 2:47 ` [RFC][PATCH 02/10] arm: mxc: base support for Freescale i.MX51 processor Amit Kucheria
2009-12-04 9:41 ` Uwe Kleine-König
2009-12-04 10:24 ` Amit Kucheria
2009-12-04 10:38 ` Russell King - ARM Linux
2009-12-04 2:47 ` [RFC][PATCH 03/10] arm: mxc: changes to common plat-mxc code to add support for i.MX5 Amit Kucheria
2009-12-04 3:12 ` Herring Robert-RA7055
2009-12-04 8:34 ` Sascha Hauer
2009-12-04 10:31 ` Amit Kucheria
2009-12-04 10:59 ` Sascha Hauer
2009-12-07 17:17 ` [RFC][PATCH 03/10] arm: mxc: changes to common plat-mxc codeto " Herring Robert-RA7055
2009-12-07 20:03 ` Robert Schwebel
2009-12-07 21:21 ` [RFC][PATCH 03/10] arm: mxc: changes to common plat-mxc codetoadd " Herring Robert-RA7055
2009-12-07 18:06 ` [RFC][PATCH 03/10] arm: mxc: changes to common plat-mxc codeto add " Herring Robert-RA7055
2009-12-04 4:05 ` [RFC][PATCH 03/10] arm: mxc: changes to common plat-mxc code to " Andres Salomon
2009-12-04 10:43 ` Russell King - ARM Linux
2009-12-04 2:47 ` [RFC][PATCH 04/10] arm: mxc: Fix Drive Strength Field in the IOMUX controller Amit Kucheria
2009-12-04 9:38 ` Uwe Kleine-König [this message]
2009-12-04 11:28 ` Sascha Hauer
2009-12-04 2:47 ` [RFC][PATCH 05/10] mxc: Add board support for the i.MX51 babbage board Amit Kucheria
2009-12-04 10:25 ` Sascha Hauer
2009-12-04 11:03 ` Sascha Hauer
2009-12-10 10:31 ` Russell King - ARM Linux
2009-12-04 2:47 ` [RFC][PATCH 06/10] fec: fix uninitialized rx buffer usage Amit Kucheria
2009-12-04 11:13 ` Sascha Hauer
2009-12-08 4:31 ` Herring Robert-RA7055
2009-12-04 2:47 ` [RFC][PATCH 07/10] fec: Add LAN8700 phy support Amit Kucheria
2009-12-04 11:15 ` Sascha Hauer
2009-12-04 2:47 ` [RFC][PATCH 08/10] arm: mxc: Add IO multiplexing support for FEC Amit Kucheria
2009-12-04 11:30 ` Sascha Hauer
2009-12-04 2:47 ` [RFC][PATCH 09/10] fec: Add ARCH_MX5 as a dependency Amit Kucheria
2009-12-04 2:47 ` [RFC][PATCH 10/10] arm: mxc: Add imx51_defconfig Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204093824.GB10910@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Dinh.Nguyen@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=daniel@caiaq.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.herring@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox