2.6.32 CONFIG_SX marked as BROKEN

2.6.32 CONFIG_SX marked as BROKEN

[Graham Murray]

Commit 412145947adfca60a4b5b4893fbae82dffa25edd marked CONFIG_SX as
Broken. The commit comments state that there are no users. We are using
SX cards in production servers. I discovered this when I attempted to
upgrade a development server to 2.6.32 and it failed to find the cards.

Re: 2.6.32 CONFIG_SX marked as BROKEN

[Alan Cox]

On Fri, 04 Dec 2009 11:08:05 +0000
Graham Murray <gmurray@webwayone.co.uk> wrote:

> Commit 412145947adfca60a4b5b4893fbae82dffa25edd marked CONFIG_SX as
> Broken. The commit comments state that there are no users. We are using
> SX cards in production servers. I discovered this when I attempted to
> upgrade a development server to 2.6.32 and it failed to find the cards.

The original long discussion with the patch was intentionally trimmed for
the kernel submit. They were marked broken not just because we could find
no users but also because the code in the kernel has some very serious
flaws which I was able to demonstrate are exploitable.

Had it merely sucked it wouldn't have been marked as broken.

The bigger problem is that the design of the ancient midlayer gs code it
uses is so broken that it really needs a major rework or the sx driver
extracting from it completely. Both are major bits of work.

Alan

Re: 2.6.32 CONFIG_SX marked as BROKEN

[Greg KH]

On Fri, Dec 04, 2009 at 11:08:05AM +0000, Graham Murray wrote:
> Commit 412145947adfca60a4b5b4893fbae82dffa25edd marked CONFIG_SX as
> Broken. The commit comments state that there are no users. We are using
> SX cards in production servers. I discovered this when I attempted to
> upgrade a development server to 2.6.32 and it failed to find the cards.

Do you have the ability to test patches to verify changes in order to
help fix up this driver?

Or could you provide a pointer to where I could get one of these cards?
I've been looking for a while and can not seem to find one anywhere.

thanks,

greg k-h

Re: 2.6.32 CONFIG_SX marked as BROKEN

[Graham Murray]

Greg KH <gregkh@suse.de> writes:

> On Fri, Dec 04, 2009 at 11:08:05AM +0000, Graham Murray wrote:
>> Commit 412145947adfca60a4b5b4893fbae82dffa25edd marked CONFIG_SX as
>> Broken. The commit comments state that there are no users. We are using
>> SX cards in production servers. I discovered this when I attempted to
>> upgrade a development server to 2.6.32 and it failed to find the cards.
>
> Do you have the ability to test patches to verify changes in order to
> help fix up this driver?

Yes, I have the ability to test patches.