public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Shaun Patterson <shaunpatterson@gmail.com>,
	pq@iki.fi, linux-kernel@vger.kernel.org,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] Spelling in in /arch/x86/mm
Date: Sat, 5 Dec 2009 08:18:22 +0100	[thread overview]
Message-ID: <20091205071822.GC25383@elte.hu> (raw)
In-Reply-To: <alpine.LNX.2.00.0912041340380.3755@pobox.suse.cz>


* Jiri Kosina <jkosina@suse.cz> wrote:

> On Fri, 4 Dec 2009, Ingo Molnar wrote:
> 
> > > Spelling fix
> > > Signed-off-by: Shaun Patterson shaunpatterson@gmail.com
> > > ---
> > > ?arch/x86/mm/kmmio.c |??? 2 +-
> > > ?1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> > > index 16ccbd7..72f1572 100644
> > > --- a/arch/x86/mm/kmmio.c
> > > +++ b/arch/x86/mm/kmmio.c
> > > @@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
> > > ? * 2. remove_kmmio_fault_pages()
> > > ? *??? Remove the pages from kmmio_page_table.
> > > ? * 3. rcu_free_kmmio_fault_pages()
> > > - *??? Actally free the kmmio_fault_page structs as with RCU.
> > > + *??? Actually free the kmmio_fault_page structs as with RCU.
> > > ? */
> > > ?void unregister_kmmio_probe(struct kmmio_probe *p)
> > > ?{
> > 
> > The fix looks good - but the patch is mangled. Please see 
> > Documentation/email-clients.txt for details.
> 
> Plus the Signed-off-by: line doesn't really have correct format (the valid 
> e-mail address format is expected here).

I can fix that - not the garbled-beyond-recognition patch though.

	Ingo

  reply	other threads:[~2009-12-05  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04  1:11 [PATCH] Spelling in in /arch/x86/mm Shaun Patterson
2009-12-04  7:00 ` Ingo Molnar
2009-12-04 12:41   ` Jiri Kosina
2009-12-05  7:18     ` Ingo Molnar [this message]
2009-12-05 15:41       ` Shaun Patterson
2009-12-06  9:16         ` [tip:x86/urgent] x86: Fix typo in arch/x86/mm/kmmio.c tip-bot for Shaun Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091205071822.GC25383@elte.hu \
    --to=mingo@elte.hu \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pq@iki.fi \
    --cc=shaunpatterson@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox