Re: [022/119] highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE

Florian Mickler
2009-12-07T09:51:30Z

On Mon, 7 Dec 2009 01:11:55 +0000 (GMT)
Hugh Dickins <hugh.dickins@tiscali.co.uk> wrote:

> On Sun, 6 Dec 2009, Greg KH wrote:
>
> > 2.6.31-stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> > From: Soeren Sandmann <sandmann@daimi.au.dk>
> >
> > commit d4515646699b6ad7b1a98ceb871296b957f3ef47 upstream.
> >
> > Previously calling debug_kmap_atomic() with these types would
> > cause spurious warnings.
> >
> > (triggered by SysProf using perf events)
> >
> > Signed-off-by: Soeren Sandmann Pedersen <sandmann@redhat.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: a.p.zijlstra@chello.nl
> > LKML-Reference: <ye8vdhz8krw.fsf@camel23.daimi.au.dk>
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> IIRC, this patch caused build failures in a number of architectures,
> those which didn't already define KM_NMI, KM_NMI_PTE or KM_IRQ_PTE
> e.g. compare the 2.6.32 arch/arm/include/asm/kmap_types.h against
> its 2.6.31 version.
>
> Should be fixable if you include the extras necessary, but I'm
> ashamed to say I've left that as an exercise for the reader ;)
>
> Hugh

grepping the git log for KM_NMI did find these two fixes in linus tree:

e8105903d78c81119754a42926951d9d17e191ba powerpc: Fix DEBUG_HIGHMEM build break from d4515646699
4ff1fa278b0bd1b2dd3c42efc0cb86788ffe05d5 [ARM] kmap: fix build errors with DEBUG_HIGHMEM enabled

hth,
Flo