From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/2] perf: Make location of kernel source configurable
Date: Mon, 7 Dec 2009 08:07:15 +0100 [thread overview]
Message-ID: <20091207070715.GC10868@elte.hu> (raw)
In-Reply-To: <20091207061839.GB5186@nowhere>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Sun, Dec 06, 2009 at 03:07:30PM +0100, Andi Kleen wrote:
> >
> > tools/perf has no support for separate object directories
> > and lots of hard coded paths assuming that the kernel source
> > is always in ../..
> >
> > As a first step of compiling it separately without messing
> > up clean source trees allow to configure the kernel source
> > location using a KERNELSRC variable
> >
> > This allows at least to copy the whole tools/perf
> > directory elsewhere and build it separately.
> >
> > The default is still ../.., so for a standard build
> > nothing changes
> >
> > This also removes a lot of ugly ../.. from the source.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
>
> It does not apply cleanly, it seems you are using 2.6.32 There have a
> been a lot of updates in this merge window.
>
> Could you please resend against latest linus tree?
Even better would be a patch against latest -tip:
http://people.redhat.com/mingo/tip.git/README
which includes the latest perf event tree.
Thanks,
Ingo
next prev parent reply other threads:[~2009-12-07 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 14:07 [PATCH] [1/2] perf: Make location of kernel source configurable Andi Kleen
2009-12-06 14:07 ` [PATCH] [2/2] perf: allow installing as perf-versionnumber Andi Kleen
2009-12-07 1:33 ` [PATCH] [1/2] perf: Make location of kernel source configurable Frederic Weisbecker
2009-12-07 5:25 ` Ingo Molnar
2009-12-07 5:31 ` Frederic Weisbecker
2009-12-07 6:18 ` Frederic Weisbecker
2009-12-07 7:07 ` Ingo Molnar [this message]
2009-12-07 10:32 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207070715.GC10868@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox