From: Andrew Morton <akpm@linux-foundation.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] kmemcheck: make bitfield annotations truly no-ops when disabled
Date: Mon, 7 Dec 2009 14:13:56 -0800 [thread overview]
Message-ID: <20091207141356.9e83fd5b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1260121333-19642-1-git-send-email-vegard.nossum@gmail.com>
On Sun, 6 Dec 2009 18:42:13 +0100
Vegard Nossum <vegard.nossum@gmail.com> wrote:
> It turns out that even zero-sized struct members (int foo[0];) will affect
> the struct layout, causing us in particular to lose 4 bytes in struct sock.
>
> This patch fixes the regression in CONFIG_KMEMCHECK=n case.
Which kernel version is the regression relative to?
Should we backport this into 2.6.32.x?
If so, we have a slight problem: someone did
s/MAYBE_BUILD_BUG_ON/BUILD_BUG_ON/ in linux-next (I have feeling it was
me ;)) so the patch I applied had that slight massaging. Perhaps the
-stable stalwarts can take care of that slight difference.
next prev parent reply other threads:[~2009-12-07 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 17:42 [PATCH] kmemcheck: make bitfield annotations truly no-ops when disabled Vegard Nossum
2009-12-07 7:30 ` Pekka Enberg
2009-12-07 22:13 ` Andrew Morton [this message]
2009-12-09 13:31 ` Pekka Enberg
2009-12-09 13:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207141356.9e83fd5b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox