From: Frederic Weisbecker <fweisbec@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH 02/13] tracing: Extract calls to trace_define_common_fields()
Date: Tue, 8 Dec 2009 09:59:37 +0100 [thread overview]
Message-ID: <20091208085935.GA4980@nowhere> (raw)
In-Reply-To: <4B1E0C7A.8070005@cn.fujitsu.com>
On Tue, Dec 08, 2009 at 04:21:14PM +0800, Li Zefan wrote:
> > The problem is that we can't know in advance Linus will take
> > a second round of tracing features in this merge window.
> >
> > I'd rather be careful and keep separating tracing fixes and
> > tracing features.
> >
> > I'm preparing a separate fix.
> >
>
> But there is no functionality change or new feature in this
> patchset, all are cleanups and fixes.
They are not _supposed_ to have functionality change :)
They are mostly cleanups, reorganization, better handling
of interfaces, etc...
All that is in the family of "features". They are improvements
that could possibly induce new bugs.
OTOH, pure fixes are only surgical patches and should not
expand their scope to a reorg or a code cleanup.
Well, it depends, I'm not preaching hard rules. But the
point is we never know if Linus will take another round
of the first category of patches in this merge window.
So it's better to keep pure fixes isolated, at least
they have good chances to keep beeing eligible
after -rc1.
next prev parent reply other threads:[~2009-12-08 8:59 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 3:13 [PATCH 00/13] tracing: various cleanups and small fixes (updated) Li Zefan
2009-12-08 3:14 ` [PATCH 01/13] tracing: Extract duplicate ftrace_raw_init_event_foo() Li Zefan
2009-12-08 7:30 ` Frederic Weisbecker
2009-12-08 7:49 ` Li Zefan
2009-12-08 8:08 ` Frederic Weisbecker
2009-12-08 13:23 ` Steven Rostedt
2009-12-14 9:45 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:14 ` [PATCH 02/13] tracing: Extract calls to trace_define_common_fields() Li Zefan
2009-12-08 5:36 ` Lai Jiangshan
2009-12-08 7:57 ` Frederic Weisbecker
2009-12-08 8:03 ` Li Zefan
2009-12-08 8:16 ` Frederic Weisbecker
2009-12-08 8:21 ` Li Zefan
2009-12-08 8:59 ` Frederic Weisbecker [this message]
2009-12-14 9:45 ` [tip:tracing/urgent] tracing: Pull up " tip-bot for Li Zefan
2009-12-08 3:14 ` [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo() Li Zefan
2009-12-08 7:43 ` Frederic Weisbecker
2009-12-08 7:49 ` Li Zefan
2009-12-08 8:11 ` Frederic Weisbecker
2009-12-14 9:46 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:15 ` [PATCH 04/13] ftrace: Return EINVAL when writing invalid val to set_ftrace_filter Li Zefan
2009-12-14 9:46 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:15 ` [PATCH 05/13] ftrace: Call trace_parser_clear() properly Li Zefan
2009-12-08 9:48 ` Frederic Weisbecker
2009-12-08 10:03 ` Li Zefan
2009-12-08 11:43 ` Frederic Weisbecker
2009-12-08 13:28 ` Steven Rostedt
2009-12-09 5:52 ` Steven Rostedt
2009-12-14 9:46 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:15 ` [PATCH 06/13] function-graph: Allow writing the same val to set_graph_function Li Zefan
2009-12-14 9:46 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:15 ` [PATCH 07/13] tracing: Use seq file for trace_options Li Zefan
2009-12-14 9:47 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:16 ` [PATCH 08/13] tracing: Use seq file for trace_clock Li Zefan
2009-12-14 9:47 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:16 ` [PATCH 09/13] tracing: Remove useless trace option Li Zefan
2009-12-14 9:47 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:17 ` [PATCH 10/13] tracing: Simplify trace_option_write() Li Zefan
2009-12-14 9:47 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:17 ` [PATCH 11/13] tracing: Change event->profile_count to be int type Li Zefan
2009-12-14 9:48 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:17 ` [PATCH 12/13] tracing/power: Remove two exports Li Zefan
2009-12-14 9:48 ` [tip:tracing/urgent] " tip-bot for Li Zefan
2009-12-08 3:18 ` [PATCH 13/13] ksym_tracer: Fix compile warnings Li Zefan
2009-12-14 9:48 ` [tip:tracing/urgent] ksym_tracer: Fix bad cast tip-bot for Li Zefan
2009-12-08 12:23 ` [PATCH 00/13] tracing: various cleanups and small fixes (updated) Frederic Weisbecker
2009-12-08 13:29 ` Steven Rostedt
2009-12-08 13:41 ` Frederic Weisbecker
2009-12-09 5:53 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2009-12-07 7:39 [PATCH 0/13] tracing: various cleanups and small fixes Li Zefan
2009-12-07 7:40 ` [PATCH 02/13] tracing: Extract calls to trace_define_common_fields() Li Zefan
2009-12-07 20:39 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208085935.GA4980@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox