[PATCH] fib-trie: code cleanup (v2)

Mathieu Desnoyers
2009-12-08T19:25:15Z

* Stephen Hemminger (shemminger@linux-foundation.org) wrote:
> On Tue, 8 Dec 2009 13:48:39 -0500
> Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>
> > /* use cache location of last found key */
> > - if (iter->pos > 0 && pos >= iter->pos && (l = fib_find_node(t, iter->key)))
> > - pos -= iter->pos;
> > + if (iter->pos > 0 && pos >= iter->pos)
> > + l = fib_find_node(t, iter->key);
> > + if (l)
> > + pos -= iter->pos;
> > else {
>
> Missing bracket's here change the semantics.

Ouch, yes. thanks.