public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] synclink_gt dropped transmit data bugfix
Date: Tue, 8 Dec 2009 13:55:10 -0800	[thread overview]
Message-ID: <20091208135510.ffd75637.akpm@linux-foundation.org> (raw)
In-Reply-To: <1260310010.3764.49.camel@x2.microgate.com>

On Tue, 08 Dec 2009 16:06:50 -0600
Paul Fulghum <paulkf@microgate.com> wrote:

> +	/* check required buffer space */
> +	bufs_needed = (size/DMABUFSIZE);
> +	if (size % DMABUFSIZE)
> +		++bufs_needed;

	bufs_needed = DIV_ROUND_UP(size, DMABUFSIZE);

?


That unsent_tbufs() call looks like it might be expensive.

  reply	other threads:[~2009-12-08 21:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 22:06 [PATCH] synclink_gt dropped transmit data bugfix Paul Fulghum
2009-12-08 21:55 ` Andrew Morton [this message]
2009-12-08 22:43   ` Paul Fulghum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091208135510.ffd75637.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox