From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jes Sorensen <jes.sorensen@gmail.com>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>,
linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
lenb@kernel.org
Subject: Re: [PATCH] Toshiba Bluetooth enabler (rfkill)
Date: Tue, 8 Dec 2009 15:47:38 +0000 [thread overview]
Message-ID: <20091208154738.GC26435@srcf.ucam.org> (raw)
In-Reply-To: <4B1E7481.6020902@gmail.com>
On Tue, Dec 08, 2009 at 04:45:05PM +0100, Jes Sorensen wrote:
> On 12/08/09 13:55, Matthew Garrett wrote:
>> The problem with that is that there's no event to indicate that the
>> switch has been turned back on, so there's no way to update the rfkill
>> core appropriately. Giving userspace potentially stale information
>> doesn't seem helpful.
>
> I believe I can call into BTST and determine whether the switch is set
> to on or not. It's quite easy to add this to the resume handler and only
> call if it's set to on.
Right, but in normal use it's an issue. Unless we get notifications for
both types of state change, we can't add an rfkill device.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-12-08 15:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 15:38 [PATCH] Toshiba Bluetooth enabler (rfkill) Jes Sorensen
2009-12-08 10:05 ` Alan Jenkins
2009-12-08 12:55 ` Matthew Garrett
2009-12-08 15:45 ` Jes Sorensen
2009-12-08 15:47 ` Matthew Garrett [this message]
2009-12-08 15:50 ` Jes Sorensen
2009-12-08 15:51 ` Matthew Garrett
2009-12-08 21:30 ` Alan Jenkins
2009-12-08 16:58 ` Toshiba Bluetooth enabler (v2) (was: Re: [PATCH] Toshiba Bluetooth enabler (rfkill)) Jes Sorensen
2009-12-09 13:17 ` Alan Jenkins
2009-12-10 13:27 ` Dan Carpenter
2009-12-10 13:47 ` Alan Jenkins
2009-12-10 15:27 ` PATCH: Toshiba Bluetooth enabler (v3) Jes Sorensen
2009-12-10 17:00 ` Alan Jenkins
2009-12-11 10:51 ` Jes Sorensen
2009-12-11 13:08 ` Alan Jenkins
2009-12-16 17:06 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208154738.GC26435@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jes.sorensen@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox