public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: u.kleine-koenig@pengutronix.de, x86@kernel.org,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH] irq: handle irq0 special only on x86
Date: Wed, 09 Dec 2009 01:41:51 -0800 (PST)	[thread overview]
Message-ID: <20091209.014151.140337246.davem@davemloft.net> (raw)
In-Reply-To: <2375c9f90912090128k70f54ee1n99421caa81c53a8f@mail.gmail.com>

From: Am^[$(D+1^[(Brico Wang <xiyou.wangcong@gmail.com>
Date: Wed, 9 Dec 2009 17:28:09 +0800

> 2009/12/9 Uwe Kleine-K^[$(D+S^[(Bnig <u.kleine-koenig@pengutronix.de>:
>> I just noticed this when digging in the irq handling. ^[,A ^[(BAt least for arm
>> this doesn't make sense. ^[,A ^[(BNot sure if x86 is the only arch this test
>> is valid for, but probably it is.
> 
> No, it is not.
> 
> Try grep -Inr 'irq0' arch/*/kernel.

The edict was sent down long ago that IRQ number zero is
special across the entire kernel tree.

If IRQ zero can happen, you should offset the IRQ values you publish
to the rest of the kernel, and translate them back when you process
them internally.

  parent reply	other threads:[~2009-12-09  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09  9:20 [PATCH] irq: handle irq0 special only on x86 Uwe Kleine-König
2009-12-09  9:28 ` Américo Wang
2009-12-09  9:35   ` Uwe Kleine-König
2009-12-09  9:41   ` David Miller [this message]
2009-12-10  8:24     ` Uwe Kleine-König
2009-12-10 16:40       ` H. Peter Anvin
2009-12-13  0:34         ` Maciej W. Rozycki
2009-12-16 14:04         ` Uwe Kleine-König
2010-01-12 15:59 ` Uwe Kleine-König
2010-01-13  4:59   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091209.014151.140337246.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=x86@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox