From: Ingo Molnar <mingo@elte.hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Bryan Donlan <bdonlan@gmail.com>,
Ulrich Drepper <drepper@redhat.com>, Timo Sirainen <tss@iki.fi>,
WANG Cong <xiyou.wangcong@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v6] Added PR_SET_PROCTITLE_AREA option for prctl()
Date: Wed, 9 Dec 2009 10:10:23 +0100 [thread overview]
Message-ID: <20091209091023.GD5129@elte.hu> (raw)
In-Reply-To: <20091208161838.B5BD.A69D9226@jp.fujitsu.com>
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> > * Bryan Donlan <bdonlan@gmail.com> wrote:
> >
> > > On Tue, Dec 8, 2009 at 12:38 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > > >
> > > > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > > >
> > > >> > The feature looks useful, but the choice of a prctl as an API is strange
> > > >> > - it limits us to the current task only - while the ability to set
> > > >> > arguments for another task looks a more generic (and potentially more
> > > >> > useful) solution.
> > > >>
> > > >> No. It's impossible.
> > > >> /proc/{pid}/cmdline read user process's memory. iow, this prctl() don't
> > > >> receive string, it receive virtual address itself. [...]
> > > >
> > > > it's not 'impossible' at all, you yourself mention ptrace:
> > >
> > > If another process is going to use ptrace to inject the cmdline string
> > > into the victim's address space, it can also temporarily hijack a
> > > thread to run prctl() on its behalf...
> >
> > That's exactly the point i made. There's no reason not to offer the API
> > i suggested as long as permissions are checked (as usual) - because
> > ptrace already allows this (and more).
>
> Confused.
>
> I think ptrace don't solve the issue of explained my patch description.
it doesnt. By 'this' i meant the security aspect. ptrace can already do
almost arbitrary alteration to any task's state.
Ingo
next prev parent reply other threads:[~2009-12-09 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 3:15 [PATCH v6] Added PR_SET_PROCTITLE_AREA option for prctl() KOSAKI Motohiro
2009-12-08 4:46 ` Ingo Molnar
2009-12-08 5:10 ` KOSAKI Motohiro
2009-12-08 5:38 ` Ingo Molnar
2009-12-08 5:56 ` KOSAKI Motohiro
2009-12-08 6:53 ` KOSAKI Motohiro
2009-12-08 6:58 ` Ingo Molnar
2009-12-08 6:28 ` Bryan Donlan
2009-12-08 6:57 ` Ingo Molnar
2009-12-08 7:19 ` KOSAKI Motohiro
2009-12-09 9:10 ` Ingo Molnar [this message]
2009-12-10 0:16 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209091023.GD5129@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=bdonlan@gmail.com \
--cc=drepper@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tss@iki.fi \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox