From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] modpost: fix asprintf warnings
Date: Wed, 9 Dec 2009 23:59:03 +0800 [thread overview]
Message-ID: <20091209155903.GB3247@hack> (raw)
In-Reply-To: <1260360143-17093-1-git-send-email-vapier@gentoo.org>
On Wed, Dec 09, 2009 at 07:02:23AM -0500, Mike Frysinger wrote:
>On compilers with security warnings enabled by default, we get:
>
>scripts/mod/modpost.c: In function 'get_markers':
>scripts/mod/modpost.c:1562: warning: ignoring return value of 'asprintf',
> declared with attribute warn_unused_result
>scripts/mod/modpost.c: In function 'add_marker':
>scripts/mod/modpost.c:1982: warning: ignoring return value of 'asprintf',
> declared with attribute warn_unused_result
>
>So check the return value and abort on errors.
>
>Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>---
> scripts/mod/modpost.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>index 801a16a..c4df538 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -1559,7 +1559,8 @@ static void get_markers(struct elf_info *info, struct module *mod)
> const char *name = strings + sym->st_value;
> const char *fmt = strchr(name, '\0') + 1;
> char *line = NULL;
>- asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt);
>+ if (asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt) == -1)
>+ fatal("asprintf() with %s failed", name);
A '\n' is needed.
> NOFAIL(line);
> mod->markers[n++] = line;
> }
>@@ -1979,7 +1980,8 @@ static void write_dump(const char *fname)
> static void add_marker(struct module *mod, const char *name, const char *fmt)
> {
> char *line = NULL;
>- asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt);
>+ if (asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt) == -1)
>+ fatal("asprintf() with %s failed", name);
> NOFAIL(line);
>
> mod->markers = NOFAIL(realloc(mod->markers, ((mod->nmarkers + 1) *
>--
>1.6.5.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
next prev parent reply other threads:[~2009-12-09 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 12:02 [PATCH] modpost: fix asprintf warnings Mike Frysinger
2009-12-09 15:59 ` Américo Wang [this message]
2009-12-09 20:31 ` Mike Frysinger
2009-12-10 1:16 ` [PATCH v2] " Mike Frysinger
2009-12-10 6:52 ` Américo Wang
2009-12-10 11:07 ` Rusty Russell
2009-12-10 11:52 ` Rusty Russell
2009-12-10 11:55 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209155903.GB3247@hack \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox