public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 1/5] [PATCH 1/5] tracing: Only call pipe_close if pipe_close is defined
Date: Wed, 09 Dec 2009 15:40:36 -0500	[thread overview]
Message-ID: <20091209205112.864968685@goodmis.org> (raw)
In-Reply-To: 20091209204035.871524827@goodmis.org

[-- Attachment #1: 0001-tracing-Only-call-pipe_close-if-pipe_close-is-define.patch --]
[-- Type: text/plain, Size: 860 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

This fixes a cut and paste error that had pipe_close get called
if pipe_open was defined (not pipe_close).

Reported-by: Kosaki Motohiro <kosaki.motohiro@jp.fujitsu.com>
LKML-Reference: <20091209153204.F4CD.A69D9226@jp.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f804b40..dc937e1 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2899,7 +2899,7 @@ static int tracing_release_pipe(struct inode *inode, struct file *file)
 		cpumask_clear_cpu(iter->cpu_file, tracing_reader_cpumask);
 
 
-	if (iter->trace->pipe_open)
+	if (iter->trace->pipe_close)
 		iter->trace->pipe_close(iter);
 
 	mutex_unlock(&trace_types_lock);
-- 
1.6.5



  reply	other threads:[~2009-12-09 20:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 20:40 [PATCH 0/5] [GIT PULL] tracing: Fixes for function graph and trace_printk Steven Rostedt
2009-12-09 20:40 ` Steven Rostedt [this message]
2009-12-09 20:40 ` [PATCH 2/5] [PATCH 2/5] tracing: Buffer the output of seq_file in case of filled buffer Steven Rostedt
2009-12-09 20:40 ` [PATCH 3/5] [PATCH 3/5] tracing: Add full state to trace_seq Steven Rostedt
2009-12-09 20:40 ` [PATCH 4/5] [PATCH 4/5] tracing: Fix function graph trace_pipe to properly display failed entries Steven Rostedt
2009-12-09 20:40 ` [PATCH 5/5] [PATCH 5/5] tracing: Remove comparing of NULL to va_list in trace_array_vprintk() Steven Rostedt
2009-12-10  7:20 ` [PATCH 0/5] [GIT PULL] tracing: Fixes for function graph and trace_printk Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091209205112.864968685@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox