public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h>
Date: Wed, 9 Dec 2009 22:06:02 +0100	[thread overview]
Message-ID: <20091209210559.GA7129@nowhere> (raw)
In-Reply-To: <1260392620.5351.48.camel@Joe-Laptop.home>

On Wed, Dec 09, 2009 at 01:03:40PM -0800, Joe Perches wrote:
> Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed
> the include, but it's still required for a different
> lock_kernel/unlock_kernel pair in nvram_open
> 
> Compiled: x86/defconfig
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
> index 2100a8f..3cfa0f6 100644
> --- a/drivers/char/nvram.c
> +++ b/drivers/char/nvram.c
> @@ -38,6 +38,7 @@
>  #define NVRAM_VERSION	"1.3"
>  
>  #include <linux/module.h>
> +#include <linux/smp_lock.h>
>  #include <linux/nvram.h>
>  
>  #define PC		1
> 
> 


I've already sent a fix for that.
See: nvram: Fix missing smp_lock.h in nvram

Thanks.


      reply	other threads:[~2009-12-09 21:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 21:03 [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h> Joe Perches
2009-12-09 21:06 ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091209210559.GA7129@nowhere \
    --to=fweisbec@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox