* [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h>
@ 2009-12-09 21:03 Joe Perches
2009-12-09 21:06 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2009-12-09 21:03 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Thomas Gleixner, LKML
Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed
the include, but it's still required for a different
lock_kernel/unlock_kernel pair in nvram_open
Compiled: x86/defconfig
Signed-off-by: Joe Perches <joe@perches.com>
---
diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
index 2100a8f..3cfa0f6 100644
--- a/drivers/char/nvram.c
+++ b/drivers/char/nvram.c
@@ -38,6 +38,7 @@
#define NVRAM_VERSION "1.3"
#include <linux/module.h>
+#include <linux/smp_lock.h>
#include <linux/nvram.h>
#define PC 1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h>
2009-12-09 21:03 [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h> Joe Perches
@ 2009-12-09 21:06 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-12-09 21:06 UTC (permalink / raw)
To: Joe Perches; +Cc: Thomas Gleixner, LKML
On Wed, Dec 09, 2009 at 01:03:40PM -0800, Joe Perches wrote:
> Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed
> the include, but it's still required for a different
> lock_kernel/unlock_kernel pair in nvram_open
>
> Compiled: x86/defconfig
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
> index 2100a8f..3cfa0f6 100644
> --- a/drivers/char/nvram.c
> +++ b/drivers/char/nvram.c
> @@ -38,6 +38,7 @@
> #define NVRAM_VERSION "1.3"
>
> #include <linux/module.h>
> +#include <linux/smp_lock.h>
> #include <linux/nvram.h>
>
> #define PC 1
>
>
I've already sent a fix for that.
See: nvram: Fix missing smp_lock.h in nvram
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-09 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-09 21:03 [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h> Joe Perches
2009-12-09 21:06 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox