Re: [PATCH] Toshiba Bluetooth enabler (rfkill)

Matthew Garrett
2009-12-08T12:55:35Z

On Tue, Dec 08, 2009 at 10:05:19AM +0000, Alan Jenkins wrote:

> I think this would benefit from an explanation.
>
>
> /* Some models include a placeholder for the TOS6205 device, but don't
> use it */ ?
>
> /* May be disabled in BIOS */ ?
>
> /* This device has _STA, not sure why, but let's honour it if disabled */ ?
>
>
> That might give us an idea of what to do if we find a model which
> doesn't have _STA :-).

TOS6205 seems to be present even on models which don't have bluetooth,
and _STA then evaluates appropriately. But having checked, the core
takes care of this so the driver shouldn't need to.

> I think you _could_ export an rfkill device. It would at least be
> useful for trouble-shooting, because it lets userspace read the
> current state in a generic way. So I would recommend doing so in the
> future, even though most current userspaces won't do anything
> interesting with it. Given that the BIOS sets the state when the
> switch is turned off, I would recommend you expose it as a "hard"
> block - so you don't let userspace change the state.

The problem with that is that there's no event to indicate that the
switch has been turned back on, so there's no way to update the rfkill
core appropriately. Giving userspace potentially stale information
doesn't seem helpful.

--
Matthew Garrett | mjg59@srcf.ucam.org