From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>,
linux-kernel@vger.kernel.org, x86team <x86@kernel.org>
Subject: Re: [2.6.32] WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy+0x30/0x3c()
Date: Thu, 10 Dec 2009 19:49:04 +0300 [thread overview]
Message-ID: <20091210164904.GE5086@lenovo> (raw)
In-Reply-To: <20091210163745.GA32563@elte.hu>
On Thu, Dec 10, 2009 at 05:37:45PM +0100, Ingo Molnar wrote:
...
> >
> > + perfmon_check_apic(&x86_pmu);
> > +
> > return 0;
> > }
>
> Similar check needed in intel_pmu_init() as well?
Yes (though p6 model already has such a check [fixed by Peter iirc])
>
> Also, i'd suggest to
> name it pmu_check_apic() or so - and why call it in the middle of of the
> PMU init functions? All PMU drivers are APIC based, so this call can be
> done right after:
>
> if (err != 0) {
> pr_cont("no PMU driver, software events only.\n");
> return;
> }
>
> pmu_check_apic();
>
> in a single place. Also, no need to pass in &x86_pmu - we have a single
> PMU driver.
>
> Thanks,
>
> Ingo
>
OK, will update and resend. Thanks for comments!
-- Cyrill
next prev parent reply other threads:[~2009-12-10 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 15:48 [2.6.32] WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy+0x30/0x3c() Ralf Hildebrandt
2009-12-10 16:13 ` Cyrill Gorcunov
2009-12-10 16:30 ` Cyrill Gorcunov
2009-12-10 16:37 ` Ingo Molnar
2009-12-10 16:49 ` Cyrill Gorcunov [this message]
2009-12-10 16:56 ` Cyrill Gorcunov
2009-12-10 17:18 ` [tip:perf/urgent] x86, perf events: Check if we have APIC enabled tip-bot for Cyrill Gorcunov
2009-12-10 18:15 ` Cyrill Gorcunov
2009-12-11 8:39 ` Christian Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210164904.GE5086@lenovo \
--to=gorcunov@gmail.com \
--cc=Ralf.Hildebrandt@charite.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox