* Return value of print_graph_prologue
@ 2009-12-11 10:12 Wenji Huang
2009-12-11 11:04 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Wenji Huang @ 2009-12-11 10:12 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Steven Rostedt, LKML
Hi,
I got confused about the return value of print_graph_prologue. See:
805 /* Latency format */
806 if (trace_flags & TRACE_ITER_LATENCY_FMT) {
807 ret = print_graph_lat_fmt(s, ent);
808 if (ret == TRACE_TYPE_PARTIAL_LINE)
809 return TRACE_TYPE_PARTIAL_LINE;
810 }
811
812 return 0;
813 }
But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
no difference between success and failure?
Should it be TRACE_TYPE_HANDLED ?
Regards,
Wenji
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Return value of print_graph_prologue
2009-12-11 10:12 Return value of print_graph_prologue Wenji Huang
@ 2009-12-11 11:04 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-12-11 11:04 UTC (permalink / raw)
To: Wenji Huang; +Cc: Steven Rostedt, LKML
On Fri, Dec 11, 2009 at 06:12:31PM +0800, Wenji Huang wrote:
> Hi,
>
> I got confused about the return value of print_graph_prologue. See:
>
> 805 /* Latency format */
> 806 if (trace_flags & TRACE_ITER_LATENCY_FMT) {
> 807 ret = print_graph_lat_fmt(s, ent);
> 808 if (ret == TRACE_TYPE_PARTIAL_LINE)
> 809 return TRACE_TYPE_PARTIAL_LINE;
> 810 }
> 811
> 812 return 0;
> 813 }
>
> But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
> no difference between success and failure?
>
> Should it be TRACE_TYPE_HANDLED ?
>
> Regards,
> Wenji
Oh, good catch, I'm preparing a fix.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-11 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-11 10:12 Return value of print_graph_prologue Wenji Huang
2009-12-11 11:04 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox