From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752959AbZLKM1b@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752959AbZLKM1b (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Dec 2009 07:27:31 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751952AbZLKM1Z
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 11 Dec 2009 07:27:25 -0500
Received: from mail-ew0-f209.google.com ([209.85.219.209]:39641 "EHLO
	mail-ew0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751932AbZLKM1Z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Dec 2009 07:27:25 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        b=pEJakeLHq1/lj4WfJmJp9cW7B61VQPvURK23fZ6GTNZ4gmQWbq9HmB3ri3jR8th1aC
         TnvL+cUtRssloVz/LLEShkV/S9JQ+vXN/oBRAVWwca/ykcdlXHBFjiLq+J6iNp36LFYe
         nO7ADafeDgf4F2GwPKZP4Ac91buG3wzEFWYHY=
Date: Fri, 11 Dec 2009 13:27:23 +0100
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Frederic Riss <frederic.riss@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Steven Rostedt <rostedt@goodmis.org>,
       Ingo Molnar <mingo@elte.hu>, Wenji Huang <wenji.huang@oracle.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] ftrace: Fix MATCH_END_ONLY filter matching
Message-ID: <20091211122721.GH5244@nowhere>
References: <4B2217D0.5000308@cn.fujitsu.com> <87d3b2040912110420w270cff7ew36a7f2389a88fdb9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87d3b2040912110420w270cff7ew36a7f2389a88fdb9@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 11, 2009 at 01:20:04PM +0100, Frederic Riss wrote:
> 2009/12/11 Li Zefan <lizf@cn.fujitsu.com>:
> > For '*foo' pattern, we should allow any string ending with
> > 'foo', but ftrace filter incorrectly disallows strings
> > like bar_foo_foo:
> [...]
> >        case MATCH_END_ONLY:
> > -               ptr = strstr(str, regex);
> > -               if (ptr && (ptr[len] == 0))
> > +               slen = strlen(str);
> > +               if (slen >= len && memcpy(str + slen - len, regex, len))
> >                        matched = 1;
> 
> Shouldn't that be memcmp() == 0? I don't see how memcpy might serve as
> a compare operator.
> 
> Fred.


Oh you're right, I reviewed it too quickly. Perhaps the star's
alignment made it possible for only one Frederic to review it
the right way...