From: Andrew Morton <akpm@linux-foundation.org>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Arjan van de Ven <arjan@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] Expose the irq_desc node in proc/irq
Date: Fri, 11 Dec 2009 14:11:58 -0800 [thread overview]
Message-ID: <20091211141158.5da226a8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20091211162532.GA2716@sgi.com>
On Fri, 11 Dec 2009 10:25:32 -0600
Dimitri Sivanich <sivanich@sgi.com> wrote:
> Expose the irq_desc node as /proc/irq/*/node.
>
:(
If the changelog provides no reason for the change, the recipient has
no reason to apply the patch.
>
> ...
> + return single_open(file, irq_node_proc_show, PDE(inode)->data);
I'd have expected checkpatch to complain about the double-space, but it
doesn't.
> ...
> /* create /proc/irq/<irq>/smp_affinity */
> proc_create_data("smp_affinity", 0600, desc->dir,
> &irq_affinity_proc_fops, (void *)(long)irq);
> +
> + proc_create_data("node", 0444, desc->dir,
> + &irq_node_proc_fops, (void *)(long)irq);
> #endif
>
> proc_create_data("spurious", 0444, desc->dir,
This should be documented in Documentation/filesystems/proc.txt,
alongside smp_affinity.
next prev parent reply other threads:[~2009-12-11 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 16:25 [PATCH] Expose the irq_desc node in proc/irq Dimitri Sivanich
2009-12-11 22:11 ` Andrew Morton [this message]
2009-12-12 11:51 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091211141158.5da226a8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=peterz@infradead.org \
--cc=sivanich@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox