From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Cedric Le Goater <clg@fr.ibm.com>
Subject: Re: [Patch] ipc: HARD_MSGMAX should be higher not lower on 64bit
Date: Fri, 11 Dec 2009 08:44:33 -0600 [thread overview]
Message-ID: <20091211144433.GA23731@us.ibm.com> (raw)
In-Reply-To: <20091211061316.3969.99500.sendpatchset@localhost.localdomain>
Quoting Amerigo Wang (amwang@redhat.com):
> It looks weird that we have HARD_MSGMAX lower on 64bit than on 32bit,
> since usually 64bit machines have more memory than 32bit machines.
It does look like this may have been an accident.
> Making it higher on 64bit seems reasonable, and keep the original
> number on 32bit.
>
> Cc: Serge E. Hallyn <serue@us.ibm.com>
> Cc: Cedric Le Goater <clg@fr.ibm.com>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
> ---
> diff --git a/include/linux/ipc_namespace.h b/include/linux/ipc_namespace.h
> index e408722..07baa38 100644
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -87,7 +87,7 @@ extern int mq_init_ns(struct ipc_namespace *ns);
> /* default values */
> #define DFLT_QUEUESMAX 256 /* max number of message queues */
> #define DFLT_MSGMAX 10 /* max number of messages in each queue */
> -#define HARD_MSGMAX (131072/sizeof(void *))
> +#define HARD_MSGMAX (32768*sizeof(void *)/4)
why /4 ? You're now making it much smaller for 32-bit than it
used to be?
> #define DFLT_MSGSIZEMAX 8192 /* max message size */
> #else
> static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
next prev parent reply other threads:[~2009-12-11 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 6:10 [Patch] ipc: HARD_MSGMAX should be higher not lower on 64bit Amerigo Wang
2009-12-11 14:44 ` Serge E. Hallyn [this message]
2009-12-11 15:21 ` Américo Wang
2009-12-11 16:11 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091211144433.GA23731@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=clg@fr.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox