public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: David Miller <davem@davemloft.net>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: usb_autopm_*() removal build failure...
Date: Fri, 11 Dec 2009 22:46:20 -0800	[thread overview]
Message-ID: <20091212064620.GA13405@suse.de> (raw)
In-Reply-To: <20091211.214714.41966763.davem@davemloft.net>

On Fri, Dec 11, 2009 at 09:47:14PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Fri, 11 Dec 2009 20:05:24 -0800
> 
> > Here's the patch, sent back in August:
> > 	 http://marc.info/?l=linux-netdev&m=125071045301270&w=2
> > 
> > Can you take it from there, or do you need me to forward it on?
> 
> I tossed this into the net-2.6 tree, but...
> 
> I would recommend that in the future when you have the
> dependency of an API change that's going to break the
> build, you take in the necessary change.  And you make
> sure such a commit is in your tree before the commit
> that removes the API.

I did at first, so I dropped the API change from my tree.  Then Alan and
Oliver pointed out that the changes were already in your tree, and I
looked and saw the first one, so just assumed the 2 other ones were
there, and turned off all network USB drivers in my build in order to
handle this.

Then yesterday, Stephen reported that this one driver failed to build,
which I didn't pick up on until today, after the tree had been sent to
Linus.

So, a mixup on my part, I'm sorry about that.

> Anyways, next time, please resolve API issues internally when you
> do things that will break the build otherwise.

Will do.

thanks for your patience.

greg k-h

  reply	other threads:[~2009-12-13  1:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12  1:45 usb_autopm_*() removal build failure David Miller
2009-12-12  3:52 ` Greg KH
2009-12-12  4:05 ` Greg KH
2009-12-12  5:47   ` David Miller
2009-12-12  6:46     ` Greg KH [this message]
2009-12-12  6:56     ` Stephen Rothwell
2009-12-12  6:59       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091212064620.GA13405@suse.de \
    --to=gregkh@suse.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox