From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: gregkh@suse.de, stern@rowland.harvard.edu,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH] kaweth: Replace runtime power management primitives
Date: Sat, 12 Dec 2009 08:15:43 +0100 [thread overview]
Message-ID: <20091212071543.GA4203@elte.hu> (raw)
In-Reply-To: <20091211.230038.179945578.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Sat, 12 Dec 2009 07:59:23 +0100
>
> >
> > FYI, there's a new build breakage on latest upstream, on allyesconfig
> > x86:
> >
> > drivers/net/usb/kaweth.c: In function kaweth_open:
> > drivers/net/usb/kaweth.c:719: error: implicit declaration of function usb_autopm_enable
> >
> > The problem appears to be that usb_autopm_enable() is obsolete and got
> > eliminated recently via:
>
> I posted about this a few hours ago, it's been resolved and a fix
> is in net-2.6 and will be pushed out soon.
thanks, i found the patch on netdev - attached below, should anyone only
subscribed to lkml run into this problem.
Ingo
-------------------->
>From cf549e36d31c8f12da1fe9aaa44702b60d967aac Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oliver@neukum.org>
Date: Wed, 19 Aug 2009 21:35:01 +0200
Subject: [PATCH] kaweth: Replace runtime power management primitives
This patch removes a rare use of the USB power management API
which won't be supported after the conversion to the new generic
runtime power management framework. Functionality is not
altered.
Signed-off-by: Oliver Neukum <oliver@neukum.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
LKML-Reference: <200908192135.01422.oliver@neukum.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/net/usb/kaweth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index 3b80e8d..f1d64ef 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -716,7 +716,7 @@ static int kaweth_open(struct net_device *net)
return 0;
err_out:
- usb_autopm_enable(kaweth->intf);
+ usb_autopm_put_interface(kaweth->intf);
return -EIO;
}
@@ -753,7 +753,7 @@ static int kaweth_close(struct net_device *net)
kaweth->status &= ~KAWETH_STATUS_CLOSING;
- usb_autopm_enable(kaweth->intf);
+ usb_autopm_put_interface(kaweth->intf);
return 0;
}
next prev parent reply other threads:[~2009-12-12 7:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 21:26 [GIT PATCH] USB patches for 2.6.33-git Greg KH
2009-12-12 6:59 ` [build failure] " Ingo Molnar
2009-12-12 7:00 ` David Miller
2009-12-12 7:15 ` Ingo Molnar [this message]
2009-12-15 0:39 ` Linus Torvalds
2009-12-15 0:52 ` Greg KH
2009-12-15 1:00 ` Linus Torvalds
2009-12-15 1:47 ` Linus Torvalds
2009-12-15 2:29 ` Linus Torvalds
2009-12-15 3:09 ` Linus Torvalds
2009-12-15 3:17 ` russ.dill
2009-12-15 4:00 ` Russ Dill
2009-12-15 4:28 ` Linus Torvalds
2009-12-15 4:44 ` Linus Torvalds
2009-12-15 14:31 ` Greg KH
2009-12-15 4:36 ` Linus Torvalds
2009-12-15 4:45 ` Russ Dill
2009-12-15 6:02 ` Linus Torvalds
2009-12-15 6:11 ` Russ Dill
2009-12-15 6:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091212071543.GA4203@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox