From: Andrew Morton <akpm@linux-foundation.org>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Julia Lawall <julia@diku.dk>,
JosephChan@via.com.tw, Scott Fang <ScottFang@viatech.com.cn>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/9] drivers/video: Correct code taking the size of a pointer
Date: Sun, 13 Dec 2009 11:43:43 -0800 [thread overview]
Message-ID: <20091213114343.a60828d3.akpm@linux-foundation.org> (raw)
In-Reply-To: <4B24E3AB.9040609@gmx.de>
On Sun, 13 Dec 2009 13:52:59 +0100 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> Hi Julia, Andrew,
>
> Julia Lawall schrieb:
> > From: Julia Lawall <julia@diku.dk>
> >
> > sizeof(viafb_gamma_table) is just the size of the pointer. This is changed
> > to the size used when calling kmalloc to initialize the pointer.
>
> this is the second patch addressing this issue ending up in my mailbox.
> At least this one is technically correct so feel free to upstream it.
> However I vote for removing this ioctl hell from viafb as most of them
> duplicate framebuffer functionality or have unknown (not clearly
> defined) functionality or at least solve a generic problem with a custom
> ioctl (which I consider bad). I had a patch ready to move this stuff to
> an extra file and print a warning that it is subject to be removed. I
> feel a bit uncomfortable about repairing broken stuff prior to removing it.
> Any comments on this subject?
>
I favour both repairing and removing broken stuff ;)
We may as well fix it if problems are known. Perhaps someone is
hitting the problem at runtime in an older kernel and needs a patch to
backport. Perhaps we later decide to revert the removal, thus
reinstating the known bug.
next prev parent reply other threads:[~2009-12-13 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 11:42 [PATCH 7/9] drivers/video: Correct code taking the size of a pointer Julia Lawall
2009-12-13 12:52 ` Florian Tobias Schandinat
2009-12-13 19:43 ` Andrew Morton [this message]
2009-12-17 19:24 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213114343.a60828d3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=FlorianSchandinat@gmx.de \
--cc=JosephChan@via.com.tw \
--cc=ScottFang@viatech.com.cn \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox