Re: [BISECTED] drm: random hang since 620f378 "drm: prune modes when ..."

[Arnd Bergmann <arnd@arndb.de>]

On Sunday 13 December 2009 12:18:24 Arnd Bergmann wrote:
> On Wednesday 09 December 2009 05:38:07 Dave Airlie wrote:
> > On Wed, 2009-12-09 at 00:07 +0100, Arnd Bergmann wrote:
> > > On Tuesday 08 December 2009, Dave Airlie wrote:
> > > > > 
> > > > > Sorry for blaming the wrong patch, especially if it already caused a lot 
> > > > > of work. I'll try blaming ec2a4c3fdc8 "drm/i915: get the bridge device
> > > > > once" now, that is the next-best candidate that my bisection pointed to,
> > > > > but I'll do more rigorous testing.
> > > 
> > > It just crashed again with both 620f378 and ec2a4c3fdc8 reverted as well, 
> > > after about an hour of uptime.
> > > 
> > ...
> > 
> > regression since 2.6.31 by the looks of it, bisection has found two
> > false positives so far.
> 
> I did a more thorough bisection this time, which points to c05422d52ee6b
> "drm/i915: remove open-coded drm_mode_object_find". The system crashed
> within minutes with 2.6.32-git and with c05422d52ee6b, but stayed up
> for 12 hours on identical kernels with this one reverted:
> 
> >  From c05422d52ee6b4cff8b63eab1a7351780518fc5e Mon Sep 17 00:00:00 2001
> >  From: Daniel Vetter <daniel.vetter@ffwll.ch>
> >  Date: Tue, 11 Aug 2009 16:05:30 +0200
> >  Subject: [PATCH] drm/i915: remove open-coded drm_mode_object_find

And now it's obvious that my computer hates me. 12 hours of uptime, one reboot
to check the old other version is broken, it crashes. I reboot into the
good version, send out the above email and the next minute it crashes again.
c05422d52ee6b is not the culprit. Sorry Daniel for blaming your patch.

	Arnd