* [PATCH] ftrace.h: Use common pr_info fmt string @ 2009-12-12 21:06 Joe Perches 2009-12-13 7:37 ` [tip:tracing/urgent] " tip-bot for Joe Perches 0 siblings, 1 reply; 6+ messages in thread From: Joe Perches @ 2009-12-12 21:06 UTC (permalink / raw) To: Steven Rostedt; +Cc: Frederic Weisbecker, Ingo Molnar, linux-kernel Reduces fmt string space a bit Signed-off-by: Joe Perches <joe@perches.com> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h index d1b3de9..c4eca38 100644 --- a/include/trace/ftrace.h +++ b/include/trace/ftrace.h @@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ ret = register_trace_##call(ftrace_raw_event_##call); \ if (ret) \ pr_info("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \ return ret; \ } \ \ ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string 2009-12-12 21:06 [PATCH] ftrace.h: Use common pr_info fmt string Joe Perches @ 2009-12-13 7:37 ` tip-bot for Joe Perches [not found] ` <1260715695.2146.412.camel@gandalf.stny.rr.com> 0 siblings, 1 reply; 6+ messages in thread From: tip-bot for Joe Perches @ 2009-12-13 7:37 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, fweisbec, joe, rostedt, tglx, mingo Commit-ID: 4819568f23a8bef0ca99b740ca60fe2450ab0aac Gitweb: http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac Author: Joe Perches <joe@perches.com> AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Sun, 13 Dec 2009 08:14:45 +0100 ftrace.h: Use common pr_info fmt string Reduces fmt string space a bit. Signed-off-by: Joe Perches <joe@perches.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <1260651974.2637.4.camel@Joe-Laptop.home> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h index d1b3de9..c4eca38 100644 --- a/include/trace/ftrace.h +++ b/include/trace/ftrace.h @@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ ret = register_trace_##call(ftrace_raw_event_##call); \ if (ret) \ pr_info("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \ return ret; \ } \ \ ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1260715695.2146.412.camel@gandalf.stny.rr.com>]
* Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string [not found] ` <1260715695.2146.412.camel@gandalf.stny.rr.com> @ 2009-12-13 14:50 ` Frederic Weisbecker 2009-12-13 17:53 ` Joe Perches 2009-12-13 18:33 ` Joe Perches 0 siblings, 2 replies; 6+ messages in thread From: Frederic Weisbecker @ 2009-12-13 14:50 UTC (permalink / raw) To: Steven Rostedt Cc: mingo, hpa, linux-kernel, joe, tglx, mingo, linux-tip-commits On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > On Sun, 2009-12-13 at 07:37 +0000, tip-bot for Joe Perches wrote: > > Commit-ID: 4819568f23a8bef0ca99b740ca60fe2450ab0aac > > Gitweb: http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac > > Author: Joe Perches <joe@perches.com> > > AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800 > > Committer: Ingo Molnar <mingo@elte.hu> > > CommitDate: Sun, 13 Dec 2009 08:14:45 +0100 > > > > ftrace.h: Use common pr_info fmt string > > > > Reduces fmt string space a bit. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Steven Rostedt <rostedt@goodmis.org> > > LKML-Reference: <1260651974.2637.4.camel@Joe-Laptop.home> > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > --- > > include/trace/ftrace.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > > index d1b3de9..c4eca38 100644 > > --- a/include/trace/ftrace.h > > +++ b/include/trace/ftrace.h > > @@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ > > ret = register_trace_##call(ftrace_raw_event_##call); \ > > if (ret) \ > > pr_info("event trace: Could not activate trace point " \ > > - "probe to " #call "\n"); \ > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > string to the string tables #func == "func" as well as add code to pass > in another parameter? > > -- Steve Yeah, I don't understand the purpose of this patch either... ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string 2009-12-13 14:50 ` Frederic Weisbecker @ 2009-12-13 17:53 ` Joe Perches 2009-12-13 18:33 ` Joe Perches 1 sibling, 0 replies; 6+ messages in thread From: Joe Perches @ 2009-12-13 17:53 UTC (permalink / raw) To: Frederic Weisbecker Cc: Steven Rostedt, mingo, hpa, linux-kernel, tglx, mingo, linux-tip-commits On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > pr_info("event trace: Could not activate trace point " \ > > > - "probe to " #call "\n"); \ > > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > > string to the string tables #func == "func" as well as add code to pass > > in another parameter? > Yeah, I don't understand the purpose of this patch either... For sched, it reduces size by ~1k. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string 2009-12-13 14:50 ` Frederic Weisbecker 2009-12-13 17:53 ` Joe Perches @ 2009-12-13 18:33 ` Joe Perches 2009-12-13 21:24 ` Frederic Weisbecker 1 sibling, 1 reply; 6+ messages in thread From: Joe Perches @ 2009-12-13 18:33 UTC (permalink / raw) To: Frederic Weisbecker Cc: Steven Rostedt, mingo, hpa, linux-kernel, tglx, mingo, linux-tip-commits On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > pr_info("event trace: Could not activate trace point " \ > > > - "probe to " #call "\n"); \ > > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > > string to the string tables #func == "func" as well as add code to pass > > in another parameter? > Yeah, I don't understand the purpose of this patch either... The patch from Li Zefan you've already queued is better http://lkml.org/lkml/2009/12/13/60 Subject: [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo() Date: Sun, 13 Dec 2009 14:08:04 +0100 From: Li Zefan <lizf@cn.fujitsu.com> Move the printk from each ftrace_raw_reg_event_foo() to its caller ftrace_event_enable_disable(). This avoids each regfunc trace event callbacks to handle a same error report that can be carried from the caller. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string 2009-12-13 18:33 ` Joe Perches @ 2009-12-13 21:24 ` Frederic Weisbecker 0 siblings, 0 replies; 6+ messages in thread From: Frederic Weisbecker @ 2009-12-13 21:24 UTC (permalink / raw) To: Joe Perches Cc: Steven Rostedt, mingo, hpa, linux-kernel, tglx, mingo, linux-tip-commits On Sun, Dec 13, 2009 at 10:33:27AM -0800, Joe Perches wrote: > On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > > pr_info("event trace: Could not activate trace point " \ > > > > - "probe to " #call "\n"); \ > > > > + "probe to %s\n", #call); \ > > > This reduces format string space a bit, but doesn't it just add another > > > string to the string tables #func == "func" as well as add code to pass > > > in another parameter? > > Yeah, I don't understand the purpose of this patch either... > > The patch from Li Zefan you've already queued is better > > http://lkml.org/lkml/2009/12/13/60 Ok. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-12-13 21:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-12 21:06 [PATCH] ftrace.h: Use common pr_info fmt string Joe Perches
2009-12-13 7:37 ` [tip:tracing/urgent] " tip-bot for Joe Perches
[not found] ` <1260715695.2146.412.camel@gandalf.stny.rr.com>
2009-12-13 14:50 ` Frederic Weisbecker
2009-12-13 17:53 ` Joe Perches
2009-12-13 18:33 ` Joe Perches
2009-12-13 21:24 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox