From: Jens Axboe <jens.axboe@oracle.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] laptop-mode: Make flushes per-device
Date: Mon, 14 Dec 2009 20:08:27 +0100 [thread overview]
Message-ID: <20091214190827.GS8742@kernel.dk> (raw)
In-Reply-To: <20091214190544.GA6589@srcf.ucam.org>
On Mon, Dec 14 2009, Matthew Garrett wrote:
> On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote:
>
> > That's because it is messy, why are you passing the request in? It
> > would be a lot more sane to pass in the queue, better still the backing
> > device.
>
> It seemed conceptually cleaner for the completion to refer to the
> request rather than anything else, but that's easily fixed.
It's rather a major layering violation, I would claim... Passing in the
bdi is design wise the cleanest.
> > What guarentees that the timer isn't running when the bdi goes away?
>
> Good point. I'll fix these and resend.
Thanks! As you can tell, laptop mode was pretty much for a laptop with a
single drive back when it was created. It definitely seems like a good
idea to make it per-drive granular now.
--
Jens Axboe
next prev parent reply other threads:[~2009-12-14 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 16:08 [PATCH] laptop-mode: Make flushes per-device Matthew Garrett
2009-12-11 16:44 ` Matthew Garrett
2009-12-11 17:54 ` Matthew Garrett
2009-12-12 12:24 ` Jens Axboe
2009-12-14 19:05 ` Matthew Garrett
2009-12-14 19:08 ` Jens Axboe [this message]
2009-12-14 19:48 ` [PATCH v2] " Matthew Garrett
2009-12-14 19:58 ` Jens Axboe
2009-12-14 20:54 ` Matthew Garrett
2009-12-15 18:21 ` [PATCH v3] " Matthew Garrett
2010-04-03 17:10 ` Matthew Garrett
2010-04-06 12:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214190827.GS8742@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox