public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Mike Galbraith <efault@gmx.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/3] perf diff: Introduce tool to show performance difference
Date: Mon, 14 Dec 2009 23:53:09 +0100	[thread overview]
Message-ID: <20091214225307.GA6048@nowhere> (raw)
In-Reply-To: <1260828571-3613-3-git-send-email-acme@infradead.org>

On Mon, Dec 14, 2009 at 08:09:31PM -0200, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> I guess it is enough to show some examples:
> 
> [root@doppio linux-2.6-tip]# rm -f perf.data*
> [root@doppio linux-2.6-tip]# ls -la perf.data*
> ls: cannot access perf.data*: No such file or directory
> [root@doppio linux-2.6-tip]# perf record -f find / > /dev/null
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.062 MB perf.data (~2699 samples) ]
> [root@doppio linux-2.6-tip]# ls -la perf.data*
> -rw------- 1 root root 74440 2009-12-14 20:03 perf.data
> [root@doppio linux-2.6-tip]# perf record -f find / > /dev/null
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.062 MB perf.data (~2692 samples) ]
> [root@doppio linux-2.6-tip]# ls -la perf.data*
> -rw------- 1 root root 74280 2009-12-14 20:03 perf.data
> -rw------- 1 root root 74440 2009-12-14 20:03 perf.data.old
> [root@doppio linux-2.6-tip]# perf diff | head -5
>    1        -34994580     /lib64/libc-2.10.1.so   _IO_vfprintf_internal
>    2        -15307806         [kernel.kallsyms]   __kmalloc
>    3    +1   +3665941     /lib64/libc-2.10.1.so   __GI_memmove
>    4    +4  +23508995     /lib64/libc-2.10.1.so   _int_malloc
>    5    +7  +38538813         [kernel.kallsyms]   __d_lookup
> [root@doppio linux-2.6-tip]# perf diff -p | head -5
>    1        +1.00%     /lib64/libc-2.10.1.so   _IO_vfprintf_internal
>    2                       [kernel.kallsyms]   __kmalloc
>    3    +1             /lib64/libc-2.10.1.so   __GI_memmove
>    4    +4             /lib64/libc-2.10.1.so   _int_malloc
>    5    +7  -1.00%         [kernel.kallsyms]   __d_lookup
> [root@doppio linux-2.6-tip]# perf diff -v | head -5
>    1        361449551 326454971 -34994580     /lib64/libc-2.10.1.so   _IO_vfprintf_internal
>    2        151009241 135701435 -15307806         [kernel.kallsyms]   __kmalloc
>    3    +1  101805328 105471269  +3665941     /lib64/libc-2.10.1.so   __GI_memmove
>    4    +4   78041440 101550435 +23508995     /lib64/libc-2.10.1.so   _int_malloc
>    5    +7   59536172  98074985 +38538813         [kernel.kallsyms]   __d_lookup
> [root@doppio linux-2.6-tip]# perf diff -vp | head -5
>    1        9.00% 8.00% +1.00%     /lib64/libc-2.10.1.so   _IO_vfprintf_internal
>    2        3.00% 3.00%                [kernel.kallsyms]   __kmalloc
>    3    +1  2.00% 2.00%            /lib64/libc-2.10.1.so   __GI_memmove
>    4    +4  2.00% 2.00%            /lib64/libc-2.10.1.so   _int_malloc
>    5    +7  1.00% 2.00% -1.00%         [kernel.kallsyms]   __d_lookup
> [root@doppio linux-2.6-tip]#



Wow, nice! :)



> 
> This should be enough for diffs where the system is non volatile, i.e. when one
> doesn't updates binaries.
> 
> For volatile environments, stay tuned for the next perf tool feature: a buildid
> cache populated by 'perf record', managed by 'perf buildid-cache' a-la ccache,
> and used by all the report tools.



Yeah. My first idea about that was to rebase the comparison against
symbols only, this is the last atom we have that is not supposed
to move in a volatile system.

And that would also apply to callchains.


  parent reply	other threads:[~2009-12-14 22:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 22:09 [PATCH 1/3] perf util: Remove setup_sorting dups Arnaldo Carvalho de Melo
2009-12-14 22:09 ` [PATCH 2/3] perf record: Rename perf.data to perf.data.old if --force/-f is used Arnaldo Carvalho de Melo
2009-12-14 22:09 ` [PATCH 3/3] perf diff: Introduce tool to show performance difference Arnaldo Carvalho de Melo
2009-12-14 22:47   ` Paul E. McKenney
2009-12-14 23:30     ` Arnaldo Carvalho de Melo
2009-12-15  5:51       ` Paul E. McKenney
2009-12-14 22:53   ` Frederic Weisbecker [this message]
     [not found]   ` <tip-86a9eee047ba09a714c3b8e27c9df2bbf715393a@git.kernel.org>
2009-12-15  9:52     ` [tip:perf/diff] " Ingo Molnar
2009-12-15 12:09       ` Frederic Weisbecker
2009-12-15 12:55       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214225307.GA6048@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=acme@redhat.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox