From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alexander Strakh <strakh@ispras.ru>
Cc: Fritz Elfert <fritz@isdn4linux.de>,
Karsten Keil <isdn@linux-pingi.de>,
Armin Schindler <mac@melware.de>,
linux-kernel@vger.kernel.org
Subject: Re: BUG null dereference in driver ./drivers/isdn/icn/icn.c
Date: Tue, 15 Dec 2009 15:20:48 +0100 [thread overview]
Message-ID: <200912151520.48798.bzolnier@gmail.com> (raw)
In-Reply-To: <200912151755.06796.strakh@ispras.ru>
On Tuesday 15 December 2009 06:55:06 pm Alexander Strakh wrote:
> KERNEL_VERSION: 2.6.32
> SUBJECT: null dereference after check
> DESCRIBE:
> In driver ./drivers/isdn/icn/icn.c in function icn_addcard:
>
> 1. If in line 1580 card2 = NULL then we goto line 1581
> 2. In line 1581 we have null dereference because printk called with card2-
> >interface.id in third parameter.
>
> 1580 if (!(card2 = icn_initcard(port, id2))) {
> 1581 printk(KERN_INFO
> 1582 "icn: (%s) half ICN-4B, port 0x%x added\n",
> 1583 card2->interface.id, port);
> 1584 return 0;
> 1585 }
After reading icn_addcard() it seems like the code was meant to use
'card' not 'card2' there.
--
Bartlomiej Zolnierkiewicz
prev parent reply other threads:[~2009-12-15 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 17:55 BUG null dereference in driver ./drivers/isdn/icn/icn.c Alexander Strakh
2009-12-15 14:20 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912151520.48798.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=fritz@isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=strakh@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox