Re: [PATCH] quota: integer constant is too large for ‘long’ type in

Jan Kara
2009-12-15T21:30:15Z

On Tue 15-12-09 07:24:14, Joe Perches wrote:
> On Tue, 2009-12-15 at 21:27 +0800, Jerry Leo wrote:
> > - info->dqi_maxblimit = 0xffffffffffffffff; /* 2^64-1 */
> > - info->dqi_maxilimit = 0xffffffffffffffff;
> > + info->dqi_maxblimit = 0xFFFFFFFFFFFFFFFFLL; /* 2^64-1 */
> > + info->dqi_maxilimit = 0xFFFFFFFFFFFFFFFFLL;
>
> ULLONG_MAX?
Not quite - I want it to really be 2^64 - 1 (on disk type is u64)
so ULLONG_MAX would be confusing IMHO.

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR