From: Jan Kara <jack@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Jerry Leo <jerryleo860202@gmail.com>,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quota: integer constant is too large for ‘long’ type in
Date: Tue, 15 Dec 2009 22:30:05 +0100 [thread overview]
Message-ID: <20091215213005.GB9554@quack.suse.cz> (raw)
In-Reply-To: <1260890654.18538.123.camel@Joe-Laptop.home>
On Tue 15-12-09 07:24:14, Joe Perches wrote:
> On Tue, 2009-12-15 at 21:27 +0800, Jerry Leo wrote:
> > - info->dqi_maxblimit = 0xffffffffffffffff; /* 2^64-1 */
> > - info->dqi_maxilimit = 0xffffffffffffffff;
> > + info->dqi_maxblimit = 0xFFFFFFFFFFFFFFFFLL; /* 2^64-1 */
> > + info->dqi_maxilimit = 0xFFFFFFFFFFFFFFFFLL;
>
> ULLONG_MAX?
Not quite - I want it to really be 2^64 - 1 (on disk type is u64)
so ULLONG_MAX would be confusing IMHO.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2009-12-15 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 13:27 [PATCH] quota: integer constant is too large for ‘long’ type in Jerry Leo
2009-12-15 15:24 ` Joe Perches
2009-12-15 21:30 ` Jan Kara [this message]
2009-12-15 21:28 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215213005.GB9554@quack.suse.cz \
--to=jack@suse.cz \
--cc=jerryleo860202@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox