Re: todays git regression (2.6.32-04008.g3ff6a46): lot of device mapper warnings

Martin K. Petersen
2009-12-15T22:09:06Z

>>>>> "Jens" == Jens Axboe <jens.axboe@oracle.com> writes:

Jens> I'll revert the bad commit tomorrow so that -rc1 wont be affected,
Jens> at least.

I'm pretty close to having a new stacking algorithm that works. If I
don't have it ready by tomorrow maybe we should commit the following
patch instead of reverting the discard changes wholesale?

diff --git a/block/blk-settings.c b/block/blk-settings.c
index dd1f1e0..65ae861 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -555,10 +555,8 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
}

if (offset &&
- (offset & (b->discard_granularity - 1)) != b->discard_alignment) {
+ (offset & (b->discard_granularity - 1)) != b->discard_alignment)
t->discard_misaligned = 1;
- ret = -1;
- }

/* If top has no alignment offset, inherit from bottom */
if (!t->alignment_offset)