* [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion @ 2009-12-16 14:35 Yong Zhang 2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang 2009-12-16 15:14 ` [PATCH 0/5] " Américo Wang 0 siblings, 2 replies; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:35 UTC (permalink / raw) To: linux-kernel The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Yong Zhang (5): aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion USB: use DECLARE_COMPLETION_ONSTACK for non-constant completion hwmon: use DECLARE_COMPLETION_ONSTACK for non-constant completion powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion arch/powerpc/platforms/iseries/viopath.c | 2 +- drivers/hwmon/ams/ams-pmu.c | 4 ++-- drivers/isdn/mISDN/l1oip_core.c | 2 +- drivers/scsi/aha152x.c | 2 +- drivers/usb/gadget/fsl_qe_udc.c | 2 +- drivers/usb/gadget/fsl_udc_core.c | 2 +- drivers/usb/gadget/langwell_udc.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/5] powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:35 [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion Yong Zhang @ 2009-12-16 14:35 ` Yong Zhang 2009-12-16 14:35 ` [PATCH 2/5] hwmon: " Yong Zhang 2009-12-16 15:14 ` [PATCH 0/5] " Américo Wang 1 sibling, 1 reply; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:35 UTC (permalink / raw) To: linux-kernel; +Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/platforms/iseries/viopath.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/iseries/viopath.c b/arch/powerpc/platforms/iseries/viopath.c index 49ff4dc..5aea94f 100644 --- a/arch/powerpc/platforms/iseries/viopath.c +++ b/arch/powerpc/platforms/iseries/viopath.c @@ -116,7 +116,7 @@ static int proc_viopath_show(struct seq_file *m, void *v) u16 vlanMap; dma_addr_t handle; HvLpEvent_Rc hvrc; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); struct device_node *node; const char *sysid; -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/5] hwmon: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang @ 2009-12-16 14:35 ` Yong Zhang 2009-12-16 14:35 ` [PATCH 3/5] USB: " Yong Zhang 0 siblings, 1 reply; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:35 UTC (permalink / raw) To: linux-kernel; +Cc: Stelian Pop, Michael Hanselmann The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: Stelian Pop <stelian@popies.net> Cc: Michael Hanselmann <linux-kernel@hansmi.ch> --- drivers/hwmon/ams/ams-pmu.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ams/ams-pmu.c b/drivers/hwmon/ams/ams-pmu.c index fb18b3d..2016629 100644 --- a/drivers/hwmon/ams/ams-pmu.c +++ b/drivers/hwmon/ams/ams-pmu.c @@ -52,7 +52,7 @@ static void ams_pmu_req_complete(struct adb_request *req) static void ams_pmu_set_register(u8 reg, u8 value) { static struct adb_request req; - DECLARE_COMPLETION(req_complete); + DECLARE_COMPLETION_ONSTACK(req_complete); req.arg = &req_complete; if (pmu_request(&req, ams_pmu_req_complete, 4, ams_pmu_cmd, 0x00, reg, value)) @@ -65,7 +65,7 @@ static void ams_pmu_set_register(u8 reg, u8 value) static u8 ams_pmu_get_register(u8 reg) { static struct adb_request req; - DECLARE_COMPLETION(req_complete); + DECLARE_COMPLETION_ONSTACK(req_complete); req.arg = &req_complete; if (pmu_request(&req, ams_pmu_req_complete, 3, ams_pmu_cmd, 0x01, reg)) -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/5] USB: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:35 ` [PATCH 2/5] hwmon: " Yong Zhang @ 2009-12-16 14:35 ` Yong Zhang 2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang 0 siblings, 1 reply; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:35 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, Anton Vorontsov, Kay Sievers, Li Yang, David Brownell, linux-usb The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Anton Vorontsov <avorontsov@ru.mvista.com> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Li Yang <leoli@freescale.com> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: linux-usb@vger.kernel.org --- drivers/usb/gadget/fsl_qe_udc.c | 2 +- drivers/usb/gadget/fsl_udc_core.c | 2 +- drivers/usb/gadget/langwell_udc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c index 7881f12..5e9e921 100644 --- a/drivers/usb/gadget/fsl_qe_udc.c +++ b/drivers/usb/gadget/fsl_qe_udc.c @@ -2694,7 +2694,7 @@ static int __devexit qe_udc_remove(struct of_device *ofdev) struct qe_ep *ep; unsigned int size; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); if (!udc_controller) return -ENODEV; diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index fa3d142..e9e4de3 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++ b/drivers/usb/gadget/fsl_udc_core.c @@ -2399,7 +2399,7 @@ static int __exit fsl_udc_remove(struct platform_device *pdev) { struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); if (!udc_controller) return -ENODEV; diff --git a/drivers/usb/gadget/langwell_udc.c b/drivers/usb/gadget/langwell_udc.c index a391351..ddfe015 100644 --- a/drivers/usb/gadget/langwell_udc.c +++ b/drivers/usb/gadget/langwell_udc.c @@ -2903,7 +2903,7 @@ static void langwell_udc_remove(struct pci_dev *pdev) { struct langwell_udc *dev = the_controller; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); BUG_ON(dev->driver); DBG(dev, "---> %s()\n", __func__); -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/5] mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:35 ` [PATCH 3/5] USB: " Yong Zhang @ 2009-12-16 14:36 ` Yong Zhang 2009-12-16 14:36 ` [PATCH 5/5] aha152x: " Yong Zhang 2009-12-16 19:00 ` [PATCH 4/5] mISDN: " Karsten Keil 0 siblings, 2 replies; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:36 UTC (permalink / raw) To: linux-kernel Cc: Karsten Keil, David S. Miller, Andreas Eversberg, Arnaldo Carvalho de Melo The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: David S. Miller <davem@davemloft.net> Cc: Andreas Eversberg <andreas@eversberg.eu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- drivers/isdn/mISDN/l1oip_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c index 7e5f30d..f1e8af5 100644 --- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c @@ -661,7 +661,7 @@ l1oip_socket_thread(void *data) size_t recvbuf_size = 1500; int recvlen; struct socket *socket = NULL; - DECLARE_COMPLETION(wait); + DECLARE_COMPLETION_ONSTACK(wait); /* allocate buffer memory */ recvbuf = kmalloc(recvbuf_size, GFP_KERNEL); -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/5] aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang @ 2009-12-16 14:36 ` Yong Zhang 2009-12-16 19:00 ` [PATCH 4/5] mISDN: " Karsten Keil 1 sibling, 0 replies; 9+ messages in thread From: Yong Zhang @ 2009-12-16 14:36 UTC (permalink / raw) To: linux-kernel; +Cc: Juergen E. Fischer, James E.J. Bottomley, linux-scsi The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Cc: Juergen E. Fischer <fischer@norbit.de> Cc: James E.J. Bottomley <James.Bottomley@suse.de> Cc: linux-scsi@vger.kernel.org --- drivers/scsi/aha152x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index 1e5478a..44e43b5 100644 --- a/drivers/scsi/aha152x.c +++ b/drivers/scsi/aha152x.c @@ -1143,7 +1143,7 @@ static int aha152x_abort(Scsi_Cmnd *SCpnt) static int aha152x_device_reset(Scsi_Cmnd * SCpnt) { struct Scsi_Host *shpnt = SCpnt->device->host; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); int ret, issued, disconnected; unsigned char old_cmd_len = SCpnt->cmd_len; unsigned long flags; -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/5] mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang 2009-12-16 14:36 ` [PATCH 5/5] aha152x: " Yong Zhang @ 2009-12-16 19:00 ` Karsten Keil 2009-12-19 4:30 ` David Miller 1 sibling, 1 reply; 9+ messages in thread From: Karsten Keil @ 2009-12-16 19:00 UTC (permalink / raw) To: Yong Zhang Cc: linux-kernel, David S. Miller, Andreas Eversberg, Arnaldo Carvalho de Melo The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> Acked-by: Karsten Keil <keil@b1-systems.de> Cc: David S. Miller <davem@davemloft.net> Cc: Andreas Eversberg <andreas@eversberg.eu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- drivers/isdn/mISDN/l1oip_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c index 7e5f30d..f1e8af5 100644 --- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c @@ -661,7 +661,7 @@ l1oip_socket_thread(void *data) size_t recvbuf_size = 1500; int recvlen; struct socket *socket = NULL; - DECLARE_COMPLETION(wait); + DECLARE_COMPLETION_ONSTACK(wait); /* allocate buffer memory */ recvbuf = kmalloc(recvbuf_size, GFP_KERNEL); ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/5] mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 19:00 ` [PATCH 4/5] mISDN: " Karsten Keil @ 2009-12-19 4:30 ` David Miller 0 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2009-12-19 4:30 UTC (permalink / raw) To: keil; +Cc: yong.zhang0, linux-kernel, andreas, acme From: Karsten Keil <keil@b1-systems.de> Date: Wed, 16 Dec 2009 20:00:20 +0100 > The _ONSTACK variant should be used for on-stack completion, > otherwise it will break lockdep. > > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> > Acked-by: Karsten Keil <keil@b1-systems.de> Applied, thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion 2009-12-16 14:35 [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion Yong Zhang 2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang @ 2009-12-16 15:14 ` Américo Wang 1 sibling, 0 replies; 9+ messages in thread From: Américo Wang @ 2009-12-16 15:14 UTC (permalink / raw) To: Yong Zhang; +Cc: linux-kernel, peterz On Wed, Dec 16, 2009 at 10:35:56PM +0800, Yong Zhang wrote: >The _ONSTACK variant should be used for on-stack completion, >otherwise it will break lockdep. > >Yong Zhang (5): > aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion > mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion > USB: use DECLARE_COMPLETION_ONSTACK for non-constant completion > hwmon: use DECLARE_COMPLETION_ONSTACK for non-constant completion > powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion These all look fine for me. Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com> For lockdep stuff, you should Cc Peter, adding him into Cc... Thanks. > > arch/powerpc/platforms/iseries/viopath.c | 2 +- > drivers/hwmon/ams/ams-pmu.c | 4 ++-- > drivers/isdn/mISDN/l1oip_core.c | 2 +- > drivers/scsi/aha152x.c | 2 +- > drivers/usb/gadget/fsl_qe_udc.c | 2 +- > drivers/usb/gadget/fsl_udc_core.c | 2 +- > drivers/usb/gadget/langwell_udc.c | 2 +- > 7 files changed, 8 insertions(+), 8 deletions(-) >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ -- Live like a child, think like the god. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-12-19 4:30 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-16 14:35 [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion Yong Zhang 2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang 2009-12-16 14:35 ` [PATCH 2/5] hwmon: " Yong Zhang 2009-12-16 14:35 ` [PATCH 3/5] USB: " Yong Zhang 2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang 2009-12-16 14:36 ` [PATCH 5/5] aha152x: " Yong Zhang 2009-12-16 19:00 ` [PATCH 4/5] mISDN: " Karsten Keil 2009-12-19 4:30 ` David Miller 2009-12-16 15:14 ` [PATCH 0/5] " Américo Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox