public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
	linux-kernel@vger.kernel.org, rubini@gnudd.com, gregkh@suse.de
Subject: Re: [PATCH 3/3] misc: use a proper range for minor number dynamic allocation
Date: Wed, 16 Dec 2009 12:01:56 -0600	[thread overview]
Message-ID: <20091216180155.GA23117@redhat.com> (raw)
In-Reply-To: <20091215233738.26188500@lxorguk.ukuu.org.uk>

On Tue, Dec 15, 2009 at 11:37:38PM +0000, Alan Cox wrote:
> > > I merged this patch, but made a note-to-self that there are remaining
> > > open issues..
> > 
> > And nothing else happened.  Can we revisit this please?
> 
> The last I saw was a request for an explanation of the users
> configuration and how he was getting so many misc devices. Its a bug in
> dlm if the dlm is doing that but I didn't see any follow up to the DLM
> folks on the subject from the reporter, so it stays NACKed and conflicts
> with the device registry.

I never saw an indication that the dlm ate up all of someone's misc
devices.  Can we ask the reporter what they were running?

> We need to know from the DLM folks/Thaddeu what is actually going on with
> that system, especially as it seems to be producing multiple
> registrations of the same misc device name which is completely broken and
> should probably be made to error anyway.

I don't believe the dlm will ever register multiple devices with the same
name.

> Whatever is going on this is the wrong "fix". If DLM should only register
> it once (as seems the intent) then DLM needs fixing or the users config
> or both. If it can register many then DLM needs fixing to not eat misc
> devices.

I explained here http://lkml.org/lkml/2009/11/9/379 that the dlm does not
use as many misc devices as has been implied.  It starts with 3, and adds
one for each *userspace* lockspace.  There are very few applications (I
know of 3) that create userspace lockspaces, and they each create about
one each.

That said, I still intend to rework the dlm to use a single device for all
lockspaces.

Dave


  parent reply	other threads:[~2009-12-16 17:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  0:30 [PATCH 1/3] misc: clear allocation bit in minor bitmap when device register fails Thadeu Lima de Souza Cascardo
2009-11-10  0:30 ` [PATCH 2/3] misc: use bitmap/bitops functions for dynamic minor number allocation Thadeu Lima de Souza Cascardo
2009-11-10  0:30   ` [PATCH 3/3] misc: use a proper range for minor number dynamic allocation Thadeu Lima de Souza Cascardo
2009-11-10  0:34     ` H. Peter Anvin
2009-11-10 10:19       ` Alan Cox
2009-11-10 16:45       ` Thadeu Lima de Souza Cascardo
2009-11-11 23:36       ` Andrew Morton
2009-12-15 22:34         ` Andrew Morton
2009-12-15 22:42           ` H. Peter Anvin
2009-12-15 22:56             ` Greg KH
2009-12-15 23:56               ` Alan Cox
2009-12-16 23:14                 ` cascardo
2009-12-16 22:51             ` cascardo
2009-12-15 23:37           ` Alan Cox
2009-12-15 23:41             ` Andrew Morton
2009-12-16 18:01             ` David Teigland [this message]
2009-12-16 17:10               ` H. Peter Anvin
2009-12-16 23:21               ` cascardo
2009-12-16 23:05             ` cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091216180155.GA23117@redhat.com \
    --to=teigland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cascardo@holoscopio.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rubini@gnudd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox