From: Greg KH <gregkh@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [patch 1/1] devtmpfs: Convert dirlock to a mutex
Date: Wed, 16 Dec 2009 14:15:41 -0800 [thread overview]
Message-ID: <20091216221541.GA8707@suse.de> (raw)
In-Reply-To: <20091216212730.308081108@linutronix.de>
On Wed, Dec 16, 2009 at 09:31:33PM -0000, Thomas Gleixner wrote:
> devtmpfs has a rw_lock dirlock which serializes delete_path and
> create_path.
>
> This code was obviously never tested with the usual set of debugging
> facilities enabled. In the dirlock held sections the code calls:
>
> - vfs functions which take mutexes
> - kmalloc(, GFP_KERNEL)
>
> In both code pathes the might sleep warning triggers and spams dmesg.
>
> Convert the rw_lock to a mutex. There is no reason why this needs to
> be a rwlock.
Many thanks, this is correct. I'll go queue it up.
greg k-h
next prev parent reply other threads:[~2009-12-16 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 21:31 [patch 1/1] devtmpfs: Convert dirlock to a mutex Thomas Gleixner
2009-12-16 22:15 ` Greg KH [this message]
2009-12-17 14:55 ` patch devtmpfs-convert-dirlock-to-a-mutex.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091216221541.GA8707@suse.de \
--to=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox