public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [git pull] VFS stuff, part 1
Date: Thu, 17 Dec 2009 01:00:32 +0000	[thread overview]
Message-ID: <20091217010032.GS14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20091217004003.GQ14381@ZenIV.linux.org.uk>

On Thu, Dec 17, 2009 at 12:40:03AM +0000, Al Viro wrote:
> On Thu, Dec 17, 2009 at 12:02:11AM +0000, Tony Vroon wrote:
> > On Wed, 2009-12-16 at 23:27 +0000, Al Viro wrote:
> > > > Do you want me to revert 1c7c474c31aea6d5cb2fb35f31d9e9e91ae466b1
> > > > locally or try linux-2.6 old enough not to have this?
> > > The former.
> > 
> > That resolves the issue completely. I am now able to boot.
> 
> Oh, fsck...  I see.  Linus, the fix is added to the same branch (and
> I'll throw the fix for removed alloc_file export there in a few minutes).

Nevermind, alloc_file export had been restored in mainline already.
So just pull from the same place, same branch (
git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ master
), there's just that one commit on top of mainline.

What happened: in absence of CONFIG_TPMFS_POSIX_ACL, shmem_mknod() had
code that boiled down to
	error = 0; /* shmem_acl_init(...), actually */
	if (error)
		cleanup
and Christoph's patch had put all that chunk under ifdef.  Which was not
an equivalent transformation, since we could arrive there with non-zero
error.  Old code used to set it to 0, new one left as-is.

  reply	other threads:[~2009-12-17  1:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 18:51 [git pull] VFS stuff, part 1 Al Viro
2009-12-16 18:53 ` Al Viro
2009-12-16 22:41 ` Alexander Beregalov
2009-12-16 22:47   ` Linus Torvalds
2009-12-16 22:54   ` Tony Vroon
2009-12-16 23:07     ` Al Viro
2009-12-16 23:13       ` Tony Vroon
2009-12-16 23:27         ` Al Viro
2009-12-17  0:02           ` Tony Vroon
2009-12-17  0:40             ` Al Viro
2009-12-17  1:00               ` Al Viro [this message]
2009-12-17  1:05               ` Tony Vroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217010032.GS14381@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox