From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Lorne Applebaum <lorne.applebaum@gmail.com>,
Matthew Garrett <mjg@redhat.com>
Subject: -tip: origin tree build failure
Date: Thu, 17 Dec 2009 07:17:25 +0100 [thread overview]
Message-ID: <20091217061725.GA26613@elte.hu> (raw)
Today's -tip failed to build because commit
0d204c34e85d1d63e5fdd3e3192747daf0ee7ec1 ("thinkpad-acpi: basic ALSA mixer
support (v2)") from today's upstream kernel causes the following build failure
on x86, for CONFIG_THINKPAD_ACPI=y && CONFIG_SOUND=m:
drivers/built-in.o: In function `volume_alsa_notify_change':
thinkpad_acpi.c:(.text+0x2d5c2d): undefined reference to `snd_ctl_notify'
thinkpad_acpi.c:(.text+0x2d5c47): undefined reference to `snd_ctl_notify'
I've applied the patch below to tip:out-of-tree.
Thanks,
Ingo
----------------->
acpi: Build CONFIG_SOUND=m build failure in CONFIG_THINKPAD_ACPI=y
Today's -tip failed to build because thinkpad_acpi.c uses sound facilities
unconditionally, without expressing its dependency on the sound subsystem:
drivers/built-in.o: In function `volume_alsa_notify_change':
thinkpad_acpi.c:(.text+0x2d5c2d): undefined reference to `snd_ctl_notify'
thinkpad_acpi.c:(.text+0x2d5c47): undefined reference to `snd_ctl_notify'
Add a Kconfig dependency on SOUND to remedy this.
Cc: Len Brown <len.brown@intel.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Lorne Applebaum <lorne.applebaum@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/platform/x86/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index f8bec62..60083e9 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -216,6 +216,7 @@ config THINKPAD_ACPI
depends on ACPI
depends on INPUT
depends on RFKILL || RFKILL = n
+ depends on SOUND
select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
select HWMON
next reply other threads:[~2009-12-17 6:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 6:17 Ingo Molnar [this message]
2009-12-17 10:04 ` -tip: origin tree build failure Henrique de Moraes Holschuh
2009-12-17 12:16 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2009-12-17 7:50 Ingo Molnar
2009-12-17 21:53 ` Myron Stowe
2009-12-26 12:36 ` Geert Uytterhoeven
2009-12-26 19:50 ` Len Brown
2009-12-27 0:24 ` Henrique de Moraes Holschuh
2009-12-28 8:26 ` Ingo Molnar
2009-12-17 9:40 Ingo Molnar
2009-12-17 12:23 ` Ingo Molnar
2009-12-17 12:55 ` Andi Kleen
2009-12-18 11:23 ` Ingo Molnar
2009-12-18 11:45 ` Andi Kleen
2010-10-28 4:52 [GIT PULL] ext4 update for 2.6.37 Theodore Ts'o
2010-10-28 7:56 ` -tip: origin tree build failure (was: [GIT PULL] ext4 update for 2.6.37) Ingo Molnar
2010-10-28 16:30 ` Linus Torvalds
2010-10-28 16:38 ` Ingo Molnar
2010-10-28 17:00 ` Linus Torvalds
2010-10-28 21:39 ` -tip: origin tree build failure Junio C Hamano
2010-10-28 21:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217061725.GA26613@elte.hu \
--to=mingo@elte.hu \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorne.applebaum@gmail.com \
--cc=mjg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox