From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764105AbZLQI0T (ORCPT ); Thu, 17 Dec 2009 03:26:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759289AbZLQI0S (ORCPT ); Thu, 17 Dec 2009 03:26:18 -0500 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:60056 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759269AbZLQI0P (ORCPT ); Thu, 17 Dec 2009 03:26:15 -0500 Date: Thu, 17 Dec 2009 17:26:09 +0900 From: Paul Mundt To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: convert to asm-generic/hardirq.h Message-ID: <20091217082609.GC20425@linux-sh.org> References: <20090804145529.GL20487@lst.de> <20090805071828.GA8415@linux-sh.org> <20091217081048.GB11571@lst.de> <20091217081554.GB20425@linux-sh.org> <20091217081916.GA11850@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091217081916.GA11850@lst.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2009 at 09:19:16AM +0100, Christoph Hellwig wrote: > On Thu, Dec 17, 2009 at 05:15:54PM +0900, Paul Mundt wrote: > > On Thu, Dec 17, 2009 at 09:10:48AM +0100, Christoph Hellwig wrote: > > > On Wed, Aug 05, 2009 at 04:18:28PM +0900, Paul Mundt wrote: > > > > On Tue, Aug 04, 2009 at 04:55:29PM +0200, Christoph Hellwig wrote: > > > > > > > > > > Signed-off-by: Christoph Hellwig > > > > > > > > > Applied, thanks. > > > > > > Did this cause problems in the end? Still doesn't seem to be in Linus' > > > tree. > > > > Nope, it was in Linus' tree for awhile, but then I needed to add an > > nmi_count and had to switch back to an arch-specific one. > > Is there a good reason to overload the irq_cpustat with that? It seems > like a quite horrible way to duplicate per-cpu data in a less efficient > way. I suppose not, but there didn't seem like a lot of good alternatives either. Shoving it in irq_cpustat is what is presently done by at least mn10300, x86, and xtensa. sparc chose stashing it in its cpuinfo struct, but then also has a meaningful per-cpu storage area. If you have any better ideas I'll certainly consider moving it.