From: Dan Carpenter <error27@gmail.com>
To: Mark Hounschell <markh@compro.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unable to format or use floppies since 2.6.28
Date: Thu, 17 Dec 2009 10:30:46 +0200 [thread overview]
Message-ID: <20091217083046.GD2121@bicker> (raw)
In-Reply-To: <4B215007.4030703@compro.net>
On Thu, Dec 10, 2009 at 02:46:15PM -0500, Mark Hounschell wrote:
> I have many boxes. They all do the same thing. Running different
> versions of SuSE, 10.3-11.2. Any kernel at or above 2.6.28 fails to
> fdformat a floppy. These same machines, using the same floppies and
> drives, running kernels older than 2.6.28 work just fine. I googled
> and found other such reports but no solution. I know better than to
> just assume it's a kernel bug but it sure looks like it could be so
> I'm inquiring about it here.
>
I don't know if this is related to your bug, but it's a weirdness in
floppy.c (from 2.6.32-rc8 sorry I suck for being up to date).
drivers/block/floppy.c
2532 size = blk_rq_cur_bytes(current_req);
2533
2534 rq_for_each_segment(bv, current_req, iter) {
2535 if (!remaining)
2536 break;
2537
2538 size = bv->bv_len;
We never use the first size = blk_rq_cur_bytes() assignment.
regards,
dan carpenter
next prev parent reply other threads:[~2009-12-17 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 19:46 Unable to format or use floppies since 2.6.28 Mark Hounschell
2009-12-12 9:33 ` ael
2009-12-17 9:04 ` Américo Wang
2009-12-17 9:19 ` Tejun Heo
2009-12-17 8:30 ` Dan Carpenter [this message]
2009-12-17 10:07 ` Mark Hounschell
2009-12-17 10:35 ` Mark Hounschell
2009-12-17 10:36 ` Alain Knaff
2009-12-17 10:45 ` Mark Hounschell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217083046.GD2121@bicker \
--to=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox