From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>,
Badari Pulavarty <pbadari@us.ibm.com>,
Jeff Moyer <jmoyer@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Zach Brown <zach.brown@oracle.com>, Alex Elder <aelder@sgi.com>,
Mark Fasheh <mfasheh@suse.com>,
Joel Becker <joel.becker@oracle.com>
Subject: Re: -tip: origin tree boot crash
Date: Thu, 17 Dec 2009 10:35:24 +0100 [thread overview]
Message-ID: <20091217093524.GA13739@lst.de> (raw)
In-Reply-To: <20091217093216.GZ14381@ZenIV.linux.org.uk>
On Thu, Dec 17, 2009 at 09:32:16AM +0000, Al Viro wrote:
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 4012885..e82adc2 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -1206,7 +1206,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode,
> * NOTE: filesystems with their own locking have to handle this
> * on their own.
> */
> - if (dio->flags & DIO_LOCKING) {
> + if (flags & DIO_LOCKING) {
> if (unlikely((rw & WRITE) && retval < 0)) {
> loff_t isize = i_size_read(inode);
> if (end > isize)
Hmm, yes that should fix it. Dio is freed at that point.
next prev parent reply other threads:[~2009-12-17 9:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 9:02 -tip: origin tree boot crash Ingo Molnar
2009-12-17 9:27 ` Christoph Hellwig
2009-12-17 9:44 ` Ingo Molnar
2009-12-17 9:32 ` Al Viro
2009-12-17 9:35 ` Christoph Hellwig [this message]
2009-12-17 9:44 ` Ingo Molnar
2009-12-17 9:52 ` Ingo Molnar
2009-12-17 9:54 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2009-12-18 16:45 Ingo Molnar
2009-12-18 17:01 ` Dave Hansen
2009-12-18 17:06 ` Ingo Molnar
2009-12-18 19:30 ` Dave Hansen
2009-12-18 20:10 ` Linus Torvalds
2009-12-24 22:00 Linux 2.6.33-rc2 - Merry Christmas Linus Torvalds
2009-12-25 10:27 ` -tip: origin tree boot crash Ingo Molnar
2009-12-25 19:49 ` Dmitry Torokhov
2009-12-26 20:19 ` Len Brown
2009-12-26 20:17 ` Len Brown
2009-12-27 4:20 ` Len Brown
2009-12-28 9:44 ` Ingo Molnar
2009-12-28 12:01 ` Ingo Molnar
2009-12-28 15:02 ` Paul Rolland
2009-12-28 16:15 ` Paul Rolland
2009-12-28 16:53 ` Paul Rolland
2009-12-28 20:17 ` Dmitry Torokhov
2009-12-30 6:14 ` Len Brown
2009-12-30 7:13 ` Paul Rolland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217093524.GA13739@lst.de \
--to=hch@lst.de \
--cc=a.p.zijlstra@chello.nl \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=jens.axboe@oracle.com \
--cc=jmoyer@redhat.com \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=mingo@elte.hu \
--cc=pbadari@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox