From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 5/6] sched: Fix broken assertion
Date: Thu, 17 Dec 2009 13:16:31 +0100 [thread overview]
Message-ID: <20091217121830.137155561@chello.nl> (raw)
In-Reply-To: 20091217121626.682772324@chello.nl
[-- Attachment #1: foo14.patch --]
[-- Type: text/plain, Size: 987 bytes --]
There's a preemption race in the set_task_cpu() debug check in that
when we get preempted after setting task->state we'd still be on the
rq proper, but fail the test.
Check for preempted tasks, since those are always on the RQ.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>
---
kernel/sched.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -2041,7 +2041,8 @@ void set_task_cpu(struct task_struct *p,
* We should never call set_task_cpu() on a blocked task,
* ttwu() will sort out the placement.
*/
- WARN_ON_ONCE(p->state != TASK_RUNNING && p->state != TASK_WAKING);
+ WARN_ON_ONCE(p->state != TASK_RUNNING && p->state != TASK_WAKING &&
+ !(task_thread_info(p)->preempt_count & PREEMPT_ACTIVE));
#endif
trace_sched_migrate_task(p, new_cpu);
--
next prev parent reply other threads:[~2009-12-17 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 12:16 [PATCH 0/6] a perf and some sched patches Peter Zijlstra
2009-12-17 12:16 ` [PATCH 1/6] sched: Move TASK_STATE_TO_CHAR_STR near the TASK_state bits Peter Zijlstra
2009-12-17 12:30 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2009-12-17 12:16 ` [PATCH 2/6] sched: Add missing state chars to TASK_STATE_TO_CHAR_STR Peter Zijlstra
2009-12-17 12:31 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2009-12-17 12:16 ` [PATCH 3/6] sched: Update task_state_arraypwith new states Peter Zijlstra
2009-12-17 12:31 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2009-12-17 12:16 ` [PATCH 4/6] sched: Assert task state bits at build time Peter Zijlstra
2009-12-17 12:31 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2009-12-17 12:16 ` Peter Zijlstra [this message]
2009-12-17 12:31 ` [tip:sched/urgent] sched: Fix broken assertion tip-bot for Peter Zijlstra
2009-12-17 12:16 ` [PATCH 6/6] perf: Dont report side-band events on each cpu for per-task-per-cpu events Peter Zijlstra
2009-12-17 12:30 ` [tip:perf/urgent] perf events: " tip-bot for Peter Zijlstra
2009-12-17 12:23 ` [PATCH 0/6] a perf and some sched patches Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217121830.137155561@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox