From: Christoph Lameter <cl@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: [this_cpu_xx V8 09/16] Allow arch to provide inc/dec functionality for each size separately
Date: Fri, 18 Dec 2009 16:26:26 -0600 [thread overview]
Message-ID: <20091218222652.446462888@quilx.com> (raw)
In-Reply-To: 20091218222617.384355422@quilx.com
[-- Attachment #1: percpu_add_inc_dec --]
[-- Type: text/plain, Size: 4752 bytes --]
Current this_cpu ops only allow an arch to specify add RMW operations or inc
and dec for all sizes. Some arches can do more efficient inc and dec
operations. Allow size specific override of fallback functions like with
the other operations.
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
---
include/linux/percpu.h | 96 +++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 90 insertions(+), 6 deletions(-)
Index: linux-2.6/include/linux/percpu.h
===================================================================
--- linux-2.6.orig/include/linux/percpu.h 2009-12-18 13:34:13.000000000 -0600
+++ linux-2.6/include/linux/percpu.h 2009-12-18 14:19:25.000000000 -0600
@@ -257,6 +257,18 @@ do { \
} \
} while (0)
+#define __pcpu_size_call_noparam(stem, variable) \
+do { \
+ switch(sizeof(variable)) { \
+ case 1: stem##1(variable);break; \
+ case 2: stem##2(variable);break; \
+ case 4: stem##4(variable);break; \
+ case 8: stem##8(variable);break; \
+ default: \
+ __bad_size_call_parameter();break; \
+ } \
+} while (0)
+
/*
* Optimized manipulation for memory allocated through the per cpu
* allocator or for addresses of per cpu variables (can be determined
@@ -352,11 +364,35 @@ do { \
#endif
#ifndef this_cpu_inc
-# define this_cpu_inc(pcp) this_cpu_add((pcp), 1)
+# ifndef this_cpu_inc_1
+# define this_cpu_inc_1(pcp) __this_cpu_add((pcp), 1)
+# endif
+# ifndef this_cpu_inc_2
+# define this_cpu_inc_2(pcp) __this_cpu_add((pcp), 1)
+# endif
+# ifndef this_cpu_inc_4
+# define this_cpu_inc_4(pcp) __this_cpu_add((pcp), 1)
+# endif
+# ifndef this_cpu_inc_8
+# define this_cpu_inc_8(pcp) __this_cpu_add((pcp), 1)
+# endif
+# define this_cpu_inc(pcp) __pcpu_size_call_noparam(this_cpu_inc_, (pcp))
#endif
#ifndef this_cpu_dec
-# define this_cpu_dec(pcp) this_cpu_sub((pcp), 1)
+# ifndef this_cpu_dec_1
+# define this_cpu_dec_1(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef this_cpu_dec_2
+# define this_cpu_dec_2(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef this_cpu_dec_4
+# define this_cpu_dec_4(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef this_cpu_dec_8
+# define this_cpu_dec_8(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# define this_cpu_dec(pcp) __pcpu_size_call_noparam(this_cpu_dec_, (pcp))
#endif
#ifndef this_cpu_and
@@ -479,11 +515,35 @@ do { \
#endif
#ifndef __this_cpu_inc
-# define __this_cpu_inc(pcp) __this_cpu_add((pcp), 1)
+# ifndef __this_cpu_inc_1
+# define __this_cpu_inc_1(pcp) __this_cpu_add_1((pcp), 1)
+# endif
+# ifndef __this_cpu_inc_2
+# define __this_cpu_inc_2(pcp) __this_cpu_add_2((pcp), 1)
+# endif
+# ifndef __this_cpu_inc_4
+# define __this_cpu_inc_4(pcp) __this_cpu_add_4((pcp), 1)
+# endif
+# ifndef __this_cpu_inc_8
+# define __this_cpu_inc_8(pcp) __this_cpu_add_8((pcp), 1)
+# endif
+# define __this_cpu_inc(pcp) __pcpu_size_call_noparam(__this_cpu_inc_, (pcp))
#endif
#ifndef __this_cpu_dec
-# define __this_cpu_dec(pcp) __this_cpu_sub((pcp), 1)
+# ifndef __this_cpu_dec_1
+# define __this_cpu_dec_1(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef __this_cpu_dec_2
+# define __this_cpu_dec_2(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef __this_cpu_dec_4
+# define __this_cpu_dec_4(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# ifndef __this_cpu_dec_8
+# define __this_cpu_dec_8(pcp) __this_cpu_sub((pcp), 1)
+# endif
+# define __this_cpu_dec(pcp) __pcpu_size_call_noparam(__this_cpu_dec_, (pcp))
#endif
#ifndef __this_cpu_and
@@ -570,11 +630,35 @@ do { \
#endif
#ifndef irqsafe_cpu_inc
-# define irqsafe_cpu_inc(pcp) irqsafe_cpu_add((pcp), 1)
+# ifndef irqsafe_cpu_inc_1
+# define irqsafe_cpu_inc_1(pcp) irqsafe_cpu_add_1((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_inc_2
+# define irqsafe_cpu_inc_2(pcp) irqsafe_cpu_add_2((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_inc_4
+# define irqsafe_cpu_inc_4(pcp) irqsafe_cpu_add_4((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_inc_8
+# define irqsafe_cpu_inc_8(pcp) irqsafe_cpu_add_8((pcp), 1)
+# endif
+# define irqsafe_cpu_inc(pcp) __pcpu_size_call_noparam(irqsafe_cpu_inc_, (pcp))
#endif
#ifndef irqsafe_cpu_dec
-# define irqsafe_cpu_dec(pcp) irqsafe_cpu_sub((pcp), 1)
+# ifndef irqsafe_cpu_dec_1
+# define irqsafe_cpu_dec_1(pcp) irqsafe_cpu_sub_1((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_dec_2
+# define irqsafe_cpu_dec_2(pcp) irqsafe_cpu_sub_2((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_dec_4
+# define irqsafe_cpu_dec_4(pcp) irqsafe_cpu_sub_4((pcp), 1)
+# endif
+# ifndef irqsafe_cpu_dec_8
+# define irqsafe_cpu_dec_8(pcp) irqsafe_cpu_sub_8((pcp), 1)
+# endif
+# define irqsafe_cpu_dec(pcp) __pcpu_size_call_noparam(irqsafe_cpu_dec_, (pcp))
#endif
#ifndef irqsafe_cpu_and
--
next prev parent reply other threads:[~2009-12-19 0:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 22:26 [this_cpu_xx V8 00/16] Per cpu atomics in core allocators, cleanup and more this_cpu_ops Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 01/16] this_cpu_ops: page allocator conversion Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 02/16] this_cpu ops: Remove pageset_notifier Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 03/16] Use this_cpu operations in slub Christoph Lameter
2009-12-20 9:11 ` Pekka Enberg
2009-12-18 22:26 ` [this_cpu_xx V8 04/16] SLUB: Get rid of dynamic DMA kmalloc cache allocation Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 05/16] this_cpu: Remove slub kmem_cache fields Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 06/16] Make slub statistics use this_cpu_inc Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 07/16] Module handling: Use this_cpu_xx to dynamically allocate counters Christoph Lameter
2009-12-21 7:47 ` Tejun Heo
2009-12-21 7:59 ` Tejun Heo
2009-12-21 8:19 ` Tejun Heo
2009-12-21 23:28 ` Rusty Russell
2009-12-22 0:02 ` Tejun Heo
2009-12-22 16:17 ` Christoph Lameter
2009-12-22 15:58 ` Christoph Lameter
2009-12-22 15:57 ` Christoph Lameter
2009-12-23 2:07 ` Tejun Heo
2010-01-04 17:22 ` Christoph Lameter
2010-01-04 17:51 ` Mathieu Desnoyers
2009-12-18 22:26 ` [this_cpu_xx V8 08/16] Remove cpu_local_xx macros Christoph Lameter
2009-12-18 22:26 ` Christoph Lameter [this message]
2009-12-21 7:25 ` [this_cpu_xx V8 09/16] Allow arch to provide inc/dec functionality for each size separately Tejun Heo
2009-12-22 15:56 ` Christoph Lameter
2009-12-23 2:08 ` Tejun Heo
2009-12-18 22:26 ` [this_cpu_xx V8 10/16] Support generating inc/dec for this_cpu_inc/dec Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 11/16] Generic support for this_cpu_cmpxchg Christoph Lameter
2009-12-19 14:45 ` Mathieu Desnoyers
2009-12-22 15:54 ` Christoph Lameter
2009-12-22 17:24 ` Mathieu Desnoyers
2010-01-04 17:21 ` Christoph Lameter
2010-01-05 22:29 ` Mathieu Desnoyers
2010-01-05 22:35 ` Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 12/16] Add percpu cmpxchg operations Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 13/16] Generic support for this_cpu_xchg Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 14/16] x86 percpu xchg operation Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 15/16] Generic support for this_cpu_add_return() Christoph Lameter
2009-12-18 22:26 ` [this_cpu_xx V8 16/16] x86 support for this_cpu_add_return Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218222652.446462888@quilx.com \
--to=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox