From: Jean Delvare <jdelvare@suse.de>
To: minyard@acm.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Martin Wilck <martin.wilck@ts.fujitsu.com>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH] IPMI: Add parameter to limit CPU usage in kipmid
Date: Sat, 19 Dec 2009 14:56:04 +0100 [thread overview]
Message-ID: <200912191456.04950.jdelvare@suse.de> (raw)
In-Reply-To: <20091217220821.GA4513@minyard.local>
Le jeudi 17 décembre 2009 23:08, Corey Minyard a écrit :
> I cleaned up the patch some. I added some state results to the list of
> things to be busy waited for (should improve performance a bit) and
> changed the schedule_timeout_interruptible back to 1, since that's
> what it's supposed to be. And I added some comments.
Thanks for doing this!
> I did some testing on my system here. On my system, kipmid uses almost
> no CPU normally. If I set the kipmid_max_busy_us value to 500, the
> interface was more than 5 times slower. I had to set the value up to
> 35000 for it to go back to the normal performance, and it was pretty
> linear between the two values. So this is definiately not for all
> systems.
>
> Can you try this out to make sure its ok?
I don't have any hardware where I can test this myself. But hopefully
Martin does?
Thanks,
--
Jean Delvare
Suse L3
next prev parent reply other threads:[~2009-12-19 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 21:23 [PATCH] IPMI: Add parameter to limit CPU usage in kipmid Corey Minyard
2009-12-16 21:42 ` Andrew Morton
2009-12-17 7:12 ` Michael Tokarev
2009-12-17 10:36 ` Jean Delvare
2009-12-17 18:34 ` Corey Minyard
2009-12-17 20:07 ` Jean Delvare
2009-12-17 22:08 ` Corey Minyard
2009-12-19 13:56 ` Jean Delvare [this message]
2010-01-14 14:02 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912191456.04950.jdelvare@suse.de \
--to=jdelvare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox